Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to update omniauth to 2 #88

Merged
merged 6 commits into from
Nov 18, 2021
Merged

Conversation

formigarafa
Copy link
Collaborator

This PR is to allow users of this gem to update omniauth to version 2 (security fix).
I have also made some adjustments to make rubocop pass.

@formigarafa
Copy link
Collaborator Author

I am not very knowlegeable about these github actions but they passed on my fork (https://github.com/formigarafa/omniauth_openid_connect/runs/2378846138).

If anyone could tell me if there is anything I could do to make it work, I would realle appreciate it. Thanks.

@stale
Copy link

stale bot commented Jun 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 18, 2021
@formigarafa
Copy link
Collaborator Author

What kind of activity this bot expects?

@stale stale bot removed the wontfix label Jun 19, 2021
@stale
Copy link

stale bot commented Aug 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 19, 2021
@formigarafa
Copy link
Collaborator Author

What kind of activity this bot expects?

@andrewshadura
Copy link
Contributor

I guess the bot is going to arrive some time soon again 🙂

@m0n9oose m0n9oose merged commit e87a906 into omniauth:master Nov 18, 2021
mcelaney pushed a commit to fastruby/omniauth_openid_connect that referenced this pull request Apr 27, 2022
* update rubocop to same version github action will run

* don't know when things got more strict: fixing or adjusting

* fix specs for newer version of omniauth

* allow upgrade omniauth to 2
papayaah added a commit to health2works/omniauth_openid_connect that referenced this pull request Oct 7, 2022
…0.4.0

* upstream/master: (32 commits)
  Fix date in CHANGELOG.md
  Fixes rubocop issues
  Setup Coveralls.io as Github Action
  Fix rubocop errors
  Replace deprecated rubocop_linter_action
  Update README.md
  Fix date on CHANGELOG.md
  Update VERSION to v0.4.0
  Update CHANGELOG.md for v0.4.0
  Support dynamic parameters to the authorize URI (omniauth#90)
  Upgrade Faker and replace Travis with Github Actions (omniauth#102)
  Try to fix rubocop documentation_url not round error.
  Make `omniauth_openid_connect` gem compatible with `omniauth v2.0` (omniauth#95)
  Fall back to the discovered jwks when no key specified (omniauth#97)
  Allow to update omniauth to 2 (omniauth#88)
  Update README.md
  Bump version to 0.3.5
  bugfix: info from decoded id_token is not exposed (omniauth#61)
  bugfix: NoMethodError (undefined method `count' for #<OpenIDConnect::ResponseObject::IdToken:0x0000000008d9dde0>): (omniauth#60)
  Bump version to 0.3.4
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants