Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUDGET APP #8

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

BUDGET APP #8

wants to merge 49 commits into from

Conversation

Omwomo
Copy link
Owner

@Omwomo Omwomo commented Dec 14, 2023

Implemented the following actions on my app.

Splash screen

  • A simple page with the name of my app and links to the sign up and log in pages.

Sign up and log in pages

  • The user should be able to register in the app with full name, email and password (all mandatory).
  • The user can log into the app using email and password.
  • If the user is not logged in, they can't access pages that require the user to be logged in (all the pages described below).

Home page (categories page)

  • When the user logs in, they are presented with the categories page.
  • For each category, the user can see their name, icon and the total amount of all the transactions that belongs to that category.
  • When the user clicks (or taps) on a category item, the application navigates to the transactions page for that category.
  • There is a button "add a new category" at the bottom that brings the user to the page to create a new category.

Transactions page

  • For a given category, the list of transactions is presented, ordered by the most recent.
  • At the top of the page the user could see the total amount for the category (sum of all of the amounts of the transactions in that category).
  • There is a button "add a new transaction" at the bottom that brings the user to the page to create a new transaction.
  • When the user clicks on the "Back" button (<), the user navigates to the home page.

"Add a new category" page

  • The user fills out a form to create a new category, indicating their name and icon (both mandatory).
  • The user clicks (or taps) the "Save" button to create the new category, and is taken to the home page on success.
  • When the user clicks on the "Back" button (<), the user navigates to the home page.

"Add a new transaction" page

  • The user fills out a form to create a new transaction with:
    • name (mandatory)
    • amount (mandatory)
    • categories (mandatory at least one)
  • The user click (or taps) the "Save" button to create the new transaction, and is taken to the transactions page for that category.
  • When the user clicks on the "Back" button (<), the user navigates to the transactions page for that category.

Testing

  • Created unit and integration tests for all the most important components of my application.

Added validations to my models

Copy link

@Olamarx Olamarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Omwomo,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that with wrong flow, you are to use gitflow for this project so the PR should be into the dev branch, not main.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

@Omwomo Omwomo mentioned this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants