Contact section #4
Conversation
…cated by the reviewer
There was a problem hiding this comment.
Hi @Omwomo,
Good job so far! 👏. Your Code is Awesome! 💪
There are some few issues 🐛 that you still need to work 🔧 on though to go to the next project ⏭️ but you are almost there! 🏃
Don't Worry 🙏
It's ok to have bugs in your code 🐛. Please, see this code review as a chance for you to learn practical coding skills and learn new tips that can improve your code quality 💯 and help you **get a better ** 💼.
I am going to guide you on how to fix them down below. 🤓
Highlights 🎯
- ✔️ No linter Errors
- ✔️ Descriptive README
- ✔️ Descriptive PR title and description
- The code is top-notch! 💯 and has a huge potential.
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Important Notes 📝
- Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
- Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Note: Please, don't Merge This Pull Request yet. Only Merge when it is Approved ✅.
Thank you for your time 🙏 and call me if you need help or clarification ☎️
- This is My GitHub:
- This is My Twitter:
- This is My linkedIn.
- This is My Slack:
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
- Your styling in some way has messed up the final outlook of your portfolio website as shown in the image below, your project's
about mesection is overlapping thecontact mesection. please kindly reevisit your styling to fix this design flaw before resubmitting 👍 - figma design
- your design
index.html
Outdated
| If you have an application you are interested in developing, a feature that you need built, | ||
| or a project that needs coding, I'd love to help with it! | ||
| </p> | ||
| <form id="fs-frm" class="fs" name="simple-contact-form" accept-charset="utf-8" action="https://formspree.io/f/{form_id}" method="post"> |
There was a problem hiding this comment.
- The link you have provided is incorrect. please kindly follow the directions in this link so you can setup your formspree account and attach your correct id properly so that users can reach out to you properly 👍
There was a problem hiding this comment.
Hi @Omwomo ,
Good job so far!
You still need to work on some issues to go to the next project, but you are almost there!
To Highlight 💯
- Linters are passing 👍
- Use of Github flow👍
Required Changes ♻️
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <section class="contact-form" id="cont-form"> | ||
| <div > | ||
| <div class="contain"> | ||
| <h1>Contact Me</h1> | ||
| <p> | ||
| If you have an application you are interested in developing, a feature that you need built, | ||
| or a project that needs coding, I'd love to help with it! | ||
| </p> | ||
| <form id="fs-frm" class="fs" name="simple-contact-form" accept-charset="utf-8" action="https://formspree.io/f/xoqzownz" method="post"> | ||
| <fieldset> | ||
|
|
||
| <input type="text" name="name" id="full-name" placeholder="Your Name" maxlength="30" required> | ||
|
|
||
| <input type="email" name="_replyto" id="email-address" placeholder="email@example.com" required> | ||
|
|
||
| <textarea name="message" id="message" rows="5" placeholder="Write your message here" maxlength="500" required></textarea> | ||
|
|
||
| <input id="sub" class="button" type="submit" value="Get in touch" required> | ||
| </fieldset> | ||
| </form> | ||
| <img class="shape" src="Shape.svg"> | ||
| </div> | ||
| </div> | ||
| </section> |
There was a problem hiding this comment.
- As requested by the previous reviewer kindly consider sticking to the Figma design for all the sections on your page mainly this contact section because currently everything is messed up the background image is totally wrong and even the other section cause working on the contact me part doesn't mean that your other parts have to be messed up so fixing that will make your website look as an exact duplicate of the provided design and that will make your work professional check the images below fro more clarrification
- your design 👇
- Figma design 👇
There was a problem hiding this comment.
Hello @divinecharlotte my review is still pending and I've made the required changes. Can you kindly activate it so it turns to required changes for me to be able to submit my project.
There was a problem hiding this comment.
Hi @Omwomo,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- Required changes fixed ✔️
- Linters passed ✔️
- GitHub flow ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
~N/B This is a new pull request I've created since the last one was not following the correct github flow, so the changes I've done for the contact-section with my partner Lucy have been committed today.
~We have created the contact section using html forms.
~We have used Formspree for data collection.
~We have styled the section according to the figma template desighn.