Add task arena worker block time #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `threading_control::is_any_other_client_active()` to verify if other arenas are requesting workers. * Add hybrid CPU detection at initialization. * On non-hybrid CPUs, make workers block for 1ms before leaving the arena, unless - more work becomes available in the arena (-> unblock and stay in the arena); - other arenas are requesting workers (-> unblock and leave the arena immediately). Signed-off-by: Dmitri Mokhov <dmitri.n.mokhov@intel.com> Signed-off-by: pavelkumbrasev <pavel.kumbrasev@intel.com>
dnmokhov
force-pushed
the
dev/dnmokhov/1
branch
from
fd4110e
to
20f0e19
Compare
dnmokhov
requested review from
JhaShweta1,
vossmjp,
pavelkumbrasev,
sarathnandu and
isaevil
isaevil
reviewed
Apr 23, 2024
dnmokhov
force-pushed
the
dev/dnmokhov/1
branch
from
7ee1539
to
6ac387d
Compare
sarathnandu
pushed a commit
that referenced
this pull request
May 8, 2024
* Add `threading_control::is_any_other_client_active()` to verify if other arenas are requesting workers. * Add hybrid CPU detection at initialization. * On non-hybrid CPUs, make workers block for 1ms before leaving the arena, unless - more work becomes available in the arena (-> unblock and stay in the arena); - other arenas are requesting workers (-> unblock and leave the arena immediately). Signed-off-by: Dmitri Mokhov <dmitri.n.mokhov@intel.com> Signed-off-by: pavelkumbrasev <pavel.kumbrasev@intel.com> (cherry picked from commit 92c8529)
sarathnandu
added a commit
that referenced
this pull request
May 8, 2024
* Increase yields multiplier on APPLE platforms * Improve machine_pause on arm64 * Add task arena worker block time (#1352) * Add hybrid CPU detection at initialization. * Show patch version in the version string Signed-off-by: pavelkumbrasev <pavel.kumbrasev@intel.com> Signed-off-by: sarathnandu <sarath.nandu.ramachandran.nair@intel.com> Signed-off-by: Isaev, Ilya ilya.isaev@intel.com Signed-off-by: Dmitri Mokhov <dmitri.n.mokhov@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
threading_control::is_any_other_client_active()to verify if other arenas are requesting workers.Add hybrid CPU detection at initialization.
On non-hybrid CPUs, make workers block for 1ms before leaving the arena, unless
Fixes performance degradation on large systems when CPU power state demotion is disabled.
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information