You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function \Recruiter\RetryPolicy\TimeTable::estimateHowManyRetriesIn assumes that the default timezone is UTC (which should be the best practice).
In case the default timezone is different than UTC (please refer to date_default_timezone_get() to known the default time zone of your PHP runtime) the estimateHowManyRetriesIn will fall in a subtle bug which causes a time travel in the future when an amount of time is subtracted from another instance of time (at [1] you can read one of the many reports about this bug).
Please note that supporting only UTC is a good idea. Maybe we should just check the result of the function date_default_timezone_get and if it is different from UTC we should throw an exception.
The function
\Recruiter\RetryPolicy\TimeTable::estimateHowManyRetriesIn
assumes that the default timezone isUTC
(which should be the best practice).In case the default timezone is different than
UTC
(please refer todate_default_timezone_get()
to known the default time zone of your PHP runtime) theestimateHowManyRetriesIn
will fall in a subtle bug which causes a time travel in the future when an amount of time is subtracted from another instance of time (at [1] you can read one of the many reports about this bug).Please note that supporting only
UTC
is a good idea. Maybe we should just check the result of the functiondate_default_timezone_get
and if it is different fromUTC
we should throw an exception.[1] - https://bugs.php.net/bug.php?id=68286
The text was updated successfully, but these errors were encountered: