Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

right clicking on tab and selecting new tab opens up 2 tabs #321

Closed
pyrates999 opened this issue Aug 12, 2024 · 6 comments
Closed

right clicking on tab and selecting new tab opens up 2 tabs #321

pyrates999 opened this issue Aug 12, 2024 · 6 comments

Comments

@pyrates999
Copy link

pyrates999 commented Aug 12, 2024

I am running Firefox 129.0 on x86-64 with TabMixPlus addon version 1.22.0.

When I right click on the currently active tab and click on New Tab (After This Tab), it will then open up 2 new tabs instead of 1 as expected.

Here is my preferences file:

TMPpref.txt

And here is the output from browser console:

TypeError: URL constructor: http://about:newtab is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js) URL constructor: http://about:newtab is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js) TypeError: URL constructor: http://about:blank is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js) URL constructor: http://about:blank is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js) TypeError: URL constructor: http://about:blank is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js) URL constructor: http://about:blank is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js) TypeError: URL constructor: http://about:newtab is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js) URL constructor: http://about:newtab is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js) TypeError: URL constructor: http://about:newtab is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js) URL constructor: http://about:newtab is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js)

But if I go to the File menu and click on New Tab, it only opens one tab as expected.

Here is the output from Browser Console:

TypeError: URL constructor: http://about:newtab is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js) URL constructor: http://about:newtab is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js)

It also seems to be putting http:// behind the internal url about:newtab.

@onemen
Copy link
Owner

onemen commented Aug 12, 2024

@pyrates999, Thank you for the report.

Download this test build

Rename it to .xpi and install it.

Firefox changed in version 129 the way it trigger menu command.
I need to make sure that there is no other command that runs twice.

Report back

@pyrates999
Copy link
Author

pyrates999 commented Aug 12, 2024

Ok, that didn't work at first. So I went to about:support and clicked on Clear Startup Cache.... Then it worked.

Here is the output from Browser Console:

TypeError: URL constructor: http://about:newtab is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js) URL constructor: http://about:newtab is not a valid URL. [background.js:439:18](moz-extension://6656771d-6779-46b9-982f-f062d768dd02/background.js)

@pyrates999
Copy link
Author

This could be another bug to fix where it tries to go to http://about:newtab instead of about:newtab

@pyrates999
Copy link
Author

Thanks for the fix!

@onemen
Copy link
Owner

onemen commented Aug 13, 2024

I don't see in my console any messages regarding about:newtab maybe it is related to another extension your are using
check in your profile for extension with id 6656771d-6779-46b9-982f-f062d768dd02

@pyrates999
Copy link
Author

You're right. This was caused by another add-on I had installed. Thanks. Now closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants