Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to write more than 1G of data using CGO engine #9

Closed
newtoncorp opened this issue Feb 5, 2016 · 1 comment
Closed

Unable to write more than 1G of data using CGO engine #9

newtoncorp opened this issue Feb 5, 2016 · 1 comment

Comments

@newtoncorp
Copy link

See : https://github.com/OneOfOne/xxhash/blob/master/xxhash_cgo.go#L111

This limitation does not apply on the pure GO engine.
Looking at the code in https://github.com/OneOfOne/xxhash/blob/master/c-trunk/xxhash.c#L875 which uses a size_t, the standard defines it as a unsigned integer with at least 16 bits. Usually it's 32bits on 32bit arch and 64bits on 64bit arch. Why is there a limit of 1G ? Either the limit is 16bits wide or the same as integer in go.

Ref (https://en.wikipedia.org/wiki/C_data_types#Size_and_pointer_difference_types)

@OneOfOne
Copy link
Owner

OneOfOne commented Feb 5, 2016

I swear there was a reason for that, but for the life of me I can't find it now.

I'll remove the limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants