-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get code base working with Xcode 12 #580
Comments
@timbms I think I've already fixed all the warnings in develop. The SessionDelegate problem is an Xcode bug, but can be worked around by renaming it in the KingFisher pod for now. |
@weakfl I overlooked your commits. Thank you for them |
@timbms agreed. Looks like migration to Alamofire 5.2 is required though. |
The workaround is to rename "SessionDelegate" to "KFSessionDelegate" in Kingfisher's Core/ImageDownloader.swift and Core/SessionDelegate.swift as explained in onevcat/Kingfisher#1517. |
@timbms I ment the workaround isn't required anymore with Alamofire 5.2 and latest Kingfisher. What's the state of the Alamofire 5 branch? |
@weakfl I fully understood you that you would rather jump to Alamofire 5. But so far, the branch is not ready. In particular the client certificate handling is not migrated to Alamofire 5 yet. |
onevcat/Kingfisher#1530 resolved in Kingfisher 5.15.4. Therefore we will make this update |
@timbms That's good news, gives us some time to update Alamofire... |
New regression checklist
Describe the bug
Code base needs to be updated to work with Xcode 12 without warnings and errors:
To Reproduce
Expected behavior
No more compile errors and warnings
The text was updated successfully, but these errors were encountered: