Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get code base working with Xcode 12 #580

Closed
3 tasks done
timbms opened this issue Sep 22, 2020 · 8 comments
Closed
3 tasks done

Get code base working with Xcode 12 #580

timbms opened this issue Sep 22, 2020 · 8 comments

Comments

@timbms
Copy link
Contributor

timbms commented Sep 22, 2020

New regression checklist

Describe the bug
Code base needs to be updated to work with Xcode 12 without warnings and errors:

  • Resolve Validate project settings: update to recommended settings
  • Resolve : 'SessionDelegate' has different definitions in different modules; first difference is definition in module 'Alamofire.Swift' found method

To Reproduce

  • Check out current version
  • Compile with Xcode 12
    Expected behavior
    No more compile errors and warnings
@weakfl
Copy link
Contributor

weakfl commented Sep 22, 2020

@timbms I think I've already fixed all the warnings in develop.

The SessionDelegate problem is an Xcode bug, but can be worked around by renaming it in the KingFisher pod for now.

@timbms
Copy link
Contributor Author

timbms commented Sep 22, 2020

@weakfl I overlooked your commits. Thank you for them
With respect to SessionDelegate we should make the current work around transparent to everybody
Then we could close the ticket

@weakfl
Copy link
Contributor

weakfl commented Sep 22, 2020

@timbms agreed. Looks like migration to Alamofire 5.2 is required though.

@timbms
Copy link
Contributor Author

timbms commented Sep 22, 2020

The workaround is to rename "SessionDelegate" to "KFSessionDelegate" in Kingfisher's Core/ImageDownloader.swift and Core/SessionDelegate.swift as explained in onevcat/Kingfisher#1517.

@timbms timbms closed this as completed Sep 22, 2020
@weakfl
Copy link
Contributor

weakfl commented Sep 22, 2020

@timbms I ment the workaround isn't required anymore with Alamofire 5.2 and latest Kingfisher. What's the state of the Alamofire 5 branch?

@timbms
Copy link
Contributor Author

timbms commented Sep 22, 2020

@weakfl I fully understood you that you would rather jump to Alamofire 5. But so far, the branch is not ready. In particular the client certificate handling is not migrated to Alamofire 5 yet.
In my understanding of Alamofire 5's handling of client certificates (see Alamofire/Alamofire#2993), it would be sufficient to change the ClientCertificateManager to load the certs into SessionConfiguration.urlCredentialStorage. Maybe you can have a look

@timbms
Copy link
Contributor Author

timbms commented Sep 24, 2020

onevcat/Kingfisher#1530 resolved in Kingfisher 5.15.4. Therefore we will make this update

@weakfl
Copy link
Contributor

weakfl commented Sep 27, 2020

@timbms That's good news, gives us some time to update Alamofire...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants