Reference invalidation doesn't track inner resource moves

[SupunS]

Current Behavior

Imagine a nested resource like:

resource Foo {
    let bar: @Bar
}

resource Bar {
    let id: UInt8
}

Then get a reference to the inner field, and move the outer resource:

// Get a reference to the inner resource
var barRef = &foo.bar as &Bar

// Move the resource
var foo2 <- foo

// Access the moved resource through the reference
barRef.id    // <-- This should panic, but currently doesn't

Expected Behavior

See above

Steps To Reproduce

See above

Environment

- Cadence version: Stable Cadence (not applicable for the master branch or any released versions)

[bluesign]

not applicable for the master branch or any released versions

is this only happening in Stable Cadence version? Or it means we only have reference tracking changes in Stables Cadence.

[SupunS]

The reference tracking is there in both branches, but the purpose of the tracking and how it is implemented is different in the two branches. e.g: in master branch, the tracking is used to keep the reference valid, whereas, in stable-cadence, tracking is used to invalidate the reference. This change was done in #1999.

This reported problem only exists in the stable cadence branch. More like a bug in #1999.

[SupunS]

Fixed in #2460