Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dapper Wallet problems with Newer Releases #1818

Closed
jacob-tucker opened this issue Dec 5, 2023 · 1 comment · Fixed by #1910
Closed

[BUG] Dapper Wallet problems with Newer Releases #1818

jacob-tucker opened this issue Dec 5, 2023 · 1 comment · Fixed by #1910
Labels
Bug Something isn't working

Comments

@jacob-tucker
Copy link

Current Behavior

When I go to execute a multi-signed transaction with Dapper Wallet, I get the following error using @onflow/fcl 1.9.0:

Screenshot 2023-12-05 at 1 45 27 PM

However will older releases like 1.0.1, it works totally fine.
This is the transnaction I'm running:

import EmeraldIdentityDapper from 0x39e42c67cc851cfb

    transaction(discordID: String) {
        prepare(admin: AuthAccount, user: AuthAccount) {
            let administrator = admin.borrow<&EmeraldIdentityDapper.Administrator>(from: EmeraldIdentityDapper.AdministratorStoragePath)
                                        ?? panic("Could not borrow the administrator")
            administrator.createEmeraldID(account: user.address, discordID: discordID)
        }

        execute {
            log("Created EmeraldID")
        }
    }

It's a multi-signed transaction where the DW user signs as well as a backend admin.

Expected Behavior

No error

Steps To Reproduce

Run a multi-signed transaction using @onflow/fcl 1.9.0

Environment

- OS: Mac
- Node: 18.18.0
- npm: 9.8.1

What are you currently working on that this is blocking?

No response

@jacob-tucker jacob-tucker added the Bug Something isn't working label Dec 5, 2023
@jimwheaton
Copy link

jimwheaton commented Jun 11, 2024

I'm also encountering this error. My project uses @onflow/fcl@1.3.2, which will install @onflow/sdk@1.5.1. It seems like a change in @onflow/sdk is causing the issue. When I step through the code, FCL does not call the custom authorization function during the pre-authz phase, so it does not send over the authorizer address (from the custom authz function) to Dapper Wallet. Dapper Wallet will then error on the authz phase with expected 2 authorizers, but got 3.

This issue does not occur with @onflow/sdk@1.2.2. To workaround this, I used npm overrides to restrict @onflow/sdk to 1.2.2.

example in package.json:

"overrides": {
  "@onflow/sdk": "1.2.2"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants