Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] accessNode.api does not work if has trailing slash #1829

Closed
jribbink opened this issue Dec 19, 2023 · 0 comments · Fixed by #1830
Closed

[BUG] accessNode.api does not work if has trailing slash #1829

jribbink opened this issue Dec 19, 2023 · 0 comments · Fixed by #1830
Assignees
@jribbink
Labels
Bug Something isn't working

Comments

@jribbink
Copy link
Contributor

Current Behavior

If the accessNode.api value has a trailing slash then it will cause the request to fail and give a confusing error.

Expected Behavior

We should either prune the slash or use the in-built URL library to parse the URL instead of string manipulation.

Steps To Reproduce

add trailing slash and try to use FCL

Environment

n/a

What are you currently working on that this is blocking?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jribbink jribbink

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PKG -- [transport-http] Use URL to join httpRequest hostname to path onflow/fcl-js
1 participant
@jribbink