Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master branch now uses flow-c1 in install-scripts #1660

Closed
NtTestAlert opened this issue Jun 24, 2024 · 4 comments · Fixed by #1663
Closed

Master branch now uses flow-c1 in install-scripts #1660

NtTestAlert opened this issue Jun 24, 2024 · 4 comments · Fixed by #1663

Comments

@NtTestAlert
Copy link

The documentation for installing flow-cli refer to master branch install scripts, as do probably a lot of scripts and pipelines.

In a recent merge the renaming of flow to flow-c1 was merged to master, breaking previous functionality and the desired interoperability

b6c8838#diff-043df5bdbf6639d7a77e1d44c5226fd7371e5259a1e4df3a0dd5d64c30dca44fR130

@NtTestAlert
Copy link
Author

(imo master branch should keep the flow exe name, the branches should include flow-c1. idk. it's not very important but breaks backward comp

@chasefleming
Copy link
Member

We should freeze the code and try to avoid another homebrew release until Cadence 1.0 is on the master branch. I believe the install script looks at the releases. I think it would work in its current state. Are you experiencing an issue, or is this forward thinking for the next release if we have one?

@turbolent
Copy link
Member

The install scripts should install the latest (non-prerelease) version by default, as flow, and have an option to install the latest pre-release version, as flow-c1.

@ianthpun
Copy link
Contributor

this should let you install the old pre-1.0 binary

sudo sh -ci "$(curl -fsSL https://raw.githubusercontent.com/onflow/flow-cli/v1.20.5/install.sh)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants