Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FungibleTokenMetadataViews in FlowToken #369

Closed
sisyphusSmiling opened this issue Jun 6, 2023 · 3 comments
Closed

Implement FungibleTokenMetadataViews in FlowToken #369

sisyphusSmiling opened this issue Jun 6, 2023 · 3 comments
Assignees
Labels
Feature Feedback SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board

Comments

@sisyphusSmiling
Copy link
Contributor

Issue To Be Solved

FlowToken needs to be updated with implementation of FungibleTokenMetadataViews introduced in FLIP 1087

Given the support for metadata, we may also consider implementing ViewResolver, though that's an optional consideration.

Suggest A Solution

Vaults should implement MetadataViews.Resolver and resolve FTView, FTDisplay, and FTVaultData.

If it's decided that FlowToken implements ViewResolver, then the relevant contract methods should also be added and resolve FTVaultData.

@joshuahannan
Copy link
Member

@sisyphusSmiling Is this something you'll be able to work on or should I handle it?

@sisyphusSmiling
Copy link
Contributor Author

@joshuahannan I can get this done if you have other work to complete. I l likely wouldn't get to it until next week as Hybrid Custody audit response and ETH Waterloo will have my attention this week

@joshuahannan
Copy link
Member

I'm gonna work on this this week @sisyphusSmiling so no need for you to do it. Thanks for offering though!

@joshuahannan joshuahannan self-assigned this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feedback SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board
Projects
None yet
Development

No branches or pull requests

2 participants