Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new gRPC method GetTransactionResultsByBlockID #306

Closed
emilic opened this issue Jun 28, 2022 · 1 comment
Closed

Support new gRPC method GetTransactionResultsByBlockID #306

emilic opened this issue Jun 28, 2022 · 1 comment
Assignees

Comments

@emilic
Copy link
Contributor

emilic commented Jun 28, 2022

Is your feature request related to a problem? Please describe.
The current sdk does not support a new gRPC method GetTransactionResultsByBlockID

Describe the solution you'd like
Support GetTransactionResultsByBlockID gRPC method

Describe alternatives you've considered
N/A

Additional context

Changes to the gRPC Access API in mainnet-18

  1. Added two new gRPC methods GetTransactionResultsByBlockID and GetTransactionsByBlockID
    (https://github.com/onflow/flow/blob/v0.3.1/protobuf/flow/access/access.proto#L62-L68)
  2. Added three new fields to the TransactionResultResponse - transaction_id, collection_id and block_height.
    (https://github.com/onflow/flow/blob/v0.3.1/protobuf/flow/access/access.proto#L228-L230)
  3. The field Parent voter IDs in the BlockHeader response has been deprecated and replaced by parent_voter_indices.
    (https://github.com/onflow/flow/blob/v0.3.1/protobuf/flow/entities/block_header.proto#L17)
  4. Similar to 3, the field signer IDs in CollectionGuarantee has been replaced with signer_indices.
    (https://github.com/onflow/flow/blob/v0.3.1/protobuf/flow/entities/collection.proto#L19)
    Diff showing changes to the gRPC Access API Protobuf file (onflow/flow@v0.2.4...v0.3.1#diff-8d4ba397a66e4a94ca6776f12a3cdea75d1eba97dd494422bc9552428697ddd2)
@emilic emilic changed the title Support new Support new gRPC method GetTransactionResultsByBlockID Jun 28, 2022
@psiemens psiemens assigned sukantoraymond and unassigned psiemens Jul 7, 2022
@SaveTheRbtz
Copy link
Contributor

First one was done as part of #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants