Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Update signature field for CollectionGuarantee and Block #921

Closed
synzhu opened this issue Jul 2, 2021 · 1 comment
Closed

[Access] Update signature field for CollectionGuarantee and Block #921

synzhu opened this issue Jul 2, 2021 · 1 comment
Assignees
Labels
S-Access Stale Label used when marking an issue stale.

Comments

@synzhu
Copy link
Contributor

synzhu commented Jul 2, 2021

For CollectionGuarantee, signatures is defined as array, https://bit.ly/2TjAQ5m, while only a single one is actually populated: https://bit.ly/3wbjrZZ
Same thing for Block:
https://bit.ly/3xeJel2
https://bit.ly/3ha2uuB

The signatures currently being used are aggregated signatures, which are intended to replace a list of multiple individual signatures.

We should update the protobuf entities to reflect the Go types.

In addition, we should also add all the other fields specified by a block, like ParentVoterIDs and ProposerID and ProposerSig (and the Payload stuff).

Since this may involve removing the old fields, it may be a breaking change for clients.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Oct 20, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Access Stale Label used when marking an issue stale.
Projects
None yet
Development

No branches or pull requests

3 participants