Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named parameters are not used for known functionalities #69

Closed
Tracked by #59
sisyphusSmiling opened this issue Jun 12, 2023 · 2 comments
Closed
Tracked by #59

Named parameters are not used for known functionalities #69

sisyphusSmiling opened this issue Jun 12, 2023 · 2 comments
Labels
question Further information is requested

Comments

@sisyphusSmiling
Copy link
Collaborator

Description

In contracts/HybridCustody.cdc:801, the display metadata view is stored in a dictionary with a hardcoded key “display”. Since the field and the functionality is already known, hardcoding the parameter can be avoided.

Recommendation

We recommend using dedicated fields for any known variables.

Discussion

This was discussed while exploring metadata views and resolution patterns for this contract. We'll want to decide if a display field should be included in ChildAccount the way it is in ProxyAccount.
@sisyphusSmiling sisyphusSmiling added the question Further information is requested label Jun 12, 2023
@sisyphusSmiling sisyphusSmiling mentioned this issue Jun 12, 2023
Closed
15 tasks
@sisyphusSmiling
Copy link
Collaborator Author

Does this occur anywhere other than the display noted in the recommendation and addressed in #89? If not, I think we're good to close this

@sisyphusSmiling
Copy link
Collaborator Author

Closing as this has been addressed in #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sisyphusSmiling