Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility problem with Symfony Serializer going from 5.2.4 to 5.2.5 #922

Open
YetiCGN opened this issue Feb 28, 2020 · 0 comments
Open

Comments

@YetiCGN
Copy link
Contributor

YetiCGN commented Feb 28, 2020

PHP version: 7.3.7
Elasticsearch version: 5.6.16
Bundle version: 5.2.5
Symfony version: 3.4.37

Going from 5.2.4 to 5.2.5 you raised the version range for ongr/elasticsearch-dsl from ~5.0 to ~5.0|~6.0. This causes problems with the Symfony Serializer in version 3.4, which does not yet have type hinting:

Compile Error: Declaration of ONGR\ElasticsearchDSL\Serializer\OrderedSerializer::normalize
($data, ?string $format = NULL, array $context = Array) must be compatible with
Symfony\Component\Serializer\Serializer::normalize($data, $format = NULL, array $context = Array)

The problem is easily fixed by declaring a conflict with ongr/elasticsearch-dsl: "~6.0" in the project composer.json or by pegging the version to something 5.x. But in my opinion, the bundle should not raise the version constraint on a point release. Unless you have a good reason for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant