Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to add elasticsearch-php to the composer. #151

Closed
saimaz opened this issue Sep 7, 2016 · 3 comments
Closed

Consider to add elasticsearch-php to the composer. #151

saimaz opened this issue Sep 7, 2016 · 3 comments
Labels

Comments

@saimaz
Copy link
Member

saimaz commented Sep 7, 2016

Maybe we should add elasticsearch-php client dependency in requirements.?

@saimaz saimaz added the question label Sep 7, 2016
@bcremer
Copy link
Contributor

bcremer commented Nov 8, 2016

Definitely in favor to add it.

Right know it's not clear which versions of elasticsearch-php are supported at all. The recently released version v5.0.0 of elasticsearch-php contains a alot of breaking changes.

It might be worth to also provide a compatibility matrix of ongr-io/ElasticsearchDSL , elasticsearch-php and elasticsearch-bin.

@saimaz
Copy link
Member Author

saimaz commented Nov 8, 2016

As of 5.0 was released we will provide compatibility matrix if necessary.

Currently, I'm testing ElasticsearchDSL in the ElasticsearchBundle and the latest stable version is fully compatible with both 2.4 and 5.0 versions.

@saimaz
Copy link
Member Author

saimaz commented Nov 9, 2016

I investigated a bit more the relation between elasticsearch-php and ElasticsearchDSL. In a nutshell, I don't think so we there is a need to include elasticsearch-php in composer require. ElasticsearchDSL provides a DSL wich represents one to one elasticsearch query in the array manner. There is nothing related to elasticsearch client here, and it's up to the user what query he builds for 5.x or 2.x, at the end library doesn't care and allows to do it for every version.

If at any point I'm wrong please correct me and reopen the issue.

@saimaz saimaz closed this as completed Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants