Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Tabs: Implement scrollbar when there is overflow #564

Closed
bryphe opened this issue Aug 4, 2017 · 8 comments
Closed

Tabs: Implement scrollbar when there is overflow #564

bryphe opened this issue Aug 4, 2017 · 8 comments
Labels
Milestone

Comments

@bryphe
Copy link
Member

bryphe commented Aug 4, 2017

The case when there is an 'overflow' (too many tabs) isn't handled today.

There should be the following:

  • A minimal scrollbar to allow easy navigating via the mouse, if desired
  • Focusing the proper tab - so even if you navigate via keyboard, that would get scrolled into view.
@bryphe bryphe added this to the 0.4 milestone Aug 4, 2017
@hoschi
Copy link

hoschi commented Aug 7, 2017

Instead of a scrollbar, is it possible to make the tabs container wrapping in to more lines than one? Like flexbox + flex-wrap. I know that behavior of IntelliJ and really liked it. With a scrollbar you not see all your opened tabs. Probably it is a problem that the editor space gets smaller so a render cycle in NVim must be triggered?

@hoschi
Copy link

hoschi commented Aug 7, 2017

@bryphe
Copy link
Member Author

bryphe commented Aug 7, 2017

@hoschi - interesting idea! I didn't think about this. Yes, it would definitely be doable, we'd just have it overflow to the next row.

Perhaps we could make it an option - I think I would prefer the look of a single-line of tabs, but I could see where some would prefer this. Thanks for the suggestion!

@hoschi
Copy link

hoschi commented Aug 7, 2017

@extr0py great 👍
Yeah, I think some people want to stick to the default vim behavior. An option would be good.

@Shou
Copy link

Shou commented Nov 15, 2017

You can also make the tabs shrink Chrome-style with Flexbox as a first measure before scrolling kicks in. I'd be glad to submit a PR if you're happy with the idea.

@bryphe
Copy link
Member Author

bryphe commented Nov 15, 2017

That sounds great @Shou, a PR would be awesome if you're up for it!

@hoschi
Copy link

hoschi commented Nov 16, 2017

Can we make this configurable? My point of wrapping tabs was to show always the full name.

@Shou when you use flexbox for shrinking can you add wrapping with flex-wrap in one go?

@bryphe
Copy link
Member Author

bryphe commented Dec 12, 2017

Looks like the work this issue was tracking is complete - having both scrollbar + wrapping behavior. I'll cose this, but we can use a new issue to track the tab-shrinking option, if desired.

@bryphe bryphe closed this as completed Dec 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants