Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET Core 2.0 #7

Closed
GiuliaMarradi opened this issue Aug 31, 2017 · 4 comments
Closed

NET Core 2.0 #7

GiuliaMarradi opened this issue Aug 31, 2017 · 4 comments

Comments

@GiuliaMarradi
Copy link

Do you plan to port this package into the new framework ?
Thanks

@onizet
Copy link
Owner

onizet commented Sep 5, 2017

Of course, when the week will count a 8th days :)
Seriously, I took a look of .NetCore 1.1 but there were too many missing features. This release is a now a good starting point but I'm really running out of time so don't expect something soon.

@jherink
Copy link

jherink commented Sep 18, 2017

Sorry I didn't mean to add the issue reference to this. It's not too pressing for me I just wanted to make a note so I didn't forget to do this myself eventually.

I did spend some time playing with the source code and here are some points of issue; perhaps it will save you some time (these are only compilation errors). I also am happy to help contribute.

  • ConverterUtility.cs - No System.Drawing.ColorTranslator class.

  • ImageHeader.cs/ImageProvisioningProvider.cs - No Image/Bitmap class. It looks like the only time these are being used is when an image size is being determined. There are several .netstandard libraries that could be used to do this; one that appeared in a quite a few searches was ImageSharp.

  • HtmlFont.cs - No FontFamily class. Could you get by with just storing & returning the name of the family as a string instead of initializing the font family?

@onizet
Copy link
Owner

onizet commented Oct 17, 2017

Hi,

I thank you for your feedback, it helps me. I found some time to migrate, so for now, the dev branch contains a beta version to support both .netcore 1.1 and .net4.5

I have to test more before moving to a release version.
Stay tuned !

@onizet
Copy link
Owner

onizet commented Jan 8, 2018

This is now released as v2.0

@onizet onizet closed this as completed Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants