Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some concerns before the implementation of the Model Zoo CI #168

Open
lyd911 opened this issue Jun 10, 2019 · 3 comments
Open

Some concerns before the implementation of the Model Zoo CI #168

lyd911 opened this issue Jun 10, 2019 · 3 comments

Comments

@lyd911
Copy link
Contributor

lyd911 commented Jun 10, 2019

About the ONNX Model Zoo CI Proposal

Sorry for the delay, and we will kick off our jobs based on the proposal submitted on April. Though getting positive feedbacks from the ONNX community, some questions still remains regarding this proposal before actual implementing.
I list some questions that the OpenLab team comes up with and want to hear the community’s idea:

  1. The current ONNX model zoo provides a .md file which contains the url to download the model. Most models provide the url in the Download section while some models didn't follow the template. For the convenience of the CI system to run the script and extract this information, it is still necessary for the model developers to upload their works strictly under the formal ONNX Model Zoo template in order to successfully trigger the CI system.
  2. The runtime used in this project shall obey the basic principle of interoperability thus the runtime should be changeable. We choose the ONNX Runtime as the default runtime and can be expanded to launch CI jobs with other runtimes in the future.
  3. Neither Model Zoo nor CI system can auto sync with the model update, so it is depend on the owner of the model to update its ONNX implementation. The owner of one specific ONNX model has the responsibility to sync with the original model and adapt to the current ONNX version.
  4. In order to run the model on the OpenLab platform, some executable source code may be modified, and the modified source code will be merged under the name of the original model (e.g. alexnet). Is the distribution of these models with modified source code causing any copyright issues?
  5. The performance test is a long term goal which the metrics are defined by each individual scenario, currently only image processing models are collected in the model zoo while other models (e.g. for nlp problems) and its test cases are still rely on the contribution of the community members.

We are looking forward to hear your idea, thanks.

@prasanthpul
Copy link
Member

We've been looking at enabling GIT LFS. That way the model binaries can be stored in Github as well instead of on external location and providing a URL. By being in Github, you should be able to trigger CI when files change. Would this simplify the CI system development?

@wangxiyuan
Copy link

@prasanthpul that's the best way!

@lyd911
Copy link
Contributor Author

lyd911 commented Jun 21, 2019

@prasanthpul Sounds great, is there a timeline when this feature can be online?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants