fix a skipped shape infer code #6049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6049 +/- ##
=======================================
Coverage 56.95% 56.95%
=======================================
Files 506 506
Lines 30467 30467
Branches 4592 4592
=======================================
Hits 17353 17353
Misses 12285 12285
Partials 829 829 ☔ View full report in Codecov by Sentry. |
|
Would it be possible to have a test for this? |
gramalingam
approved these changes
Apr 3, 2024
Let me add a test (after merging this in). Liqun is busy with something else right now. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
Add a unit test for the fix introduced by #6049 --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
gramalingam
added a commit
to gramalingam/onnx
that referenced
this pull request
Apr 12, 2024
Add a unit test for the fix introduced by onnx#6049 --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
Apr 12, 2024
### Description <!-- - Describe your changes. --> ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
gramalingam
added a commit
to gramalingam/onnx
that referenced
this pull request
Apr 12, 2024
Add a unit test for the fix introduced by onnx#6049 --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
cjvolzka
pushed a commit
that referenced
this pull request
Apr 29, 2024
### Description <!-- - Describe your changes. --> ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: Liqun Fu <liqfu@microsoft.com> (cherry picked from commit fa0b899)
Merged
cjvolzka
added a commit
that referenced
this pull request
May 9, 2024
### Description
Check-pick commits from `main` into `rel-1.16.1` branch
### Motivation and Context
Fix 1.16.0 issues and enabled 1.16.1 builds by cherry-picking the
following PRs from `main` into the `1.16.1` branch
* Fixes since 1.16.0 release
* #6049
* #6048
* #6080
* #6122
* Update CI and Build to enable 1.16.1 builds
* #6106
* #6129
* #6075
* #6117
---------
Co-authored-by: liqun Fu <liqfu@microsoft.com>
Co-authored-by: G. Ramalingam <grama@microsoft.com>
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
gramalingam
added a commit
to gramalingam/onnx
that referenced
this pull request
Jun 6, 2024
Add a unit test for the fix introduced by onnx#6049 --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If shape-inference encounters a custom-op, inference results are not updated for subsequent nodes.
See PR #6068 for an example and test-case illustrating the issue.