Fix input names for quantize/dequantize ONNX backend tests #6122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adrianlizarraga <adlizarraga@microsoft.com>
Signed-off-by: adrianlizarraga <adlizarraga@microsoft.com>
Signed-off-by: adrianlizarraga <adlizarraga@microsoft.com>
Signed-off-by: adrianlizarraga <adlizarraga@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6122 +/- ##
==========================================
+ Coverage 56.95% 57.04% +0.08%
==========================================
Files 506 506
Lines 30467 30935 +468
Branches 4592 4592
==========================================
+ Hits 17353 17646 +293
- Misses 12285 12463 +178
+ Partials 829 826 -3 ☔ View full report in Codecov by Sentry. |
xadupre
approved these changes
May 3, 2024
|
@xadupre @gramalingam Would it be possible to cherry-pick this PR for 1.16.1? It would allow onnxruntime to run the int4 q/dq node tests. |
|
@cjvolzka : would it be possible to include this PR for the patch-release? |
cjvolzka
pushed a commit
that referenced
this pull request
May 3, 2024
### Description #6123 The input pb files for the following ONNX backend node tests have incorrect names that do not match the ONNX model: - test_dequantizelinear_uint4 - test_dequantizelinear_int4 - test_quantizelinear_e4m3fn - test_quantizelinear_e5m2 - test_quantizelinear_uint4 - test_quantizelinear_int4 ### Motivation and Context The mismatch in input names causes issues when running these backend tests via ONNX Runtime. --------- Signed-off-by: adrianlizarraga <adlizarraga@microsoft.com> (cherry picked from commit 3bddb4d)
cjvolzka
pushed a commit
that referenced
this pull request
May 3, 2024
### Description #6123 The input pb files for the following ONNX backend node tests have incorrect names that do not match the ONNX model: - test_dequantizelinear_uint4 - test_dequantizelinear_int4 - test_quantizelinear_e4m3fn - test_quantizelinear_e5m2 - test_quantizelinear_uint4 - test_quantizelinear_int4 ### Motivation and Context The mismatch in input names causes issues when running these backend tests via ONNX Runtime. --------- Signed-off-by: Adrian Lizarraga <adlizarraga@microsoft.com> (cherry picked from commit 3bddb4d)
|
@gramalingam Sure. I added this to the existing 1.16.1 cherry-pick PR. |
isdanni
pushed a commit
to isdanni/onnx
that referenced
this pull request
May 6, 2024
### Description onnx#6123 The input pb files for the following ONNX backend node tests have incorrect names that do not match the ONNX model: - test_dequantizelinear_uint4 - test_dequantizelinear_int4 - test_quantizelinear_e4m3fn - test_quantizelinear_e5m2 - test_quantizelinear_uint4 - test_quantizelinear_int4 ### Motivation and Context The mismatch in input names causes issues when running these backend tests via ONNX Runtime. --------- Signed-off-by: adrianlizarraga <adlizarraga@microsoft.com> Signed-off-by: isdanni <leedanni@gmail.com>
Merged
cjvolzka
added a commit
that referenced
this pull request
May 9, 2024
### Description
Check-pick commits from `main` into `rel-1.16.1` branch
### Motivation and Context
Fix 1.16.0 issues and enabled 1.16.1 builds by cherry-picking the
following PRs from `main` into the `1.16.1` branch
* Fixes since 1.16.0 release
* #6049
* #6048
* #6080
* #6122
* Update CI and Build to enable 1.16.1 builds
* #6106
* #6129
* #6075
* #6117
---------
Co-authored-by: liqun Fu <liqfu@microsoft.com>
Co-authored-by: G. Ramalingam <grama@microsoft.com>
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
Jun 6, 2024
### Description onnx#6123 The input pb files for the following ONNX backend node tests have incorrect names that do not match the ONNX model: - test_dequantizelinear_uint4 - test_dequantizelinear_int4 - test_quantizelinear_e4m3fn - test_quantizelinear_e5m2 - test_quantizelinear_uint4 - test_quantizelinear_int4 ### Motivation and Context The mismatch in input names causes issues when running these backend tests via ONNX Runtime. --------- Signed-off-by: adrianlizarraga <adlizarraga@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6123
The input pb files for the following ONNX backend node tests have incorrect names that do not match the ONNX model:
Motivation and Context
The mismatch in input names causes issues when running these backend tests via ONNX Runtime.