Add missing shape inference check for DequantizeLinear #6080
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
justinchuby
approved these changes
Apr 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6080 +/- ##
==========================================
+ Coverage 56.95% 57.03% +0.08%
==========================================
Files 506 506
Lines 30467 30935 +468
Branches 4592 4592
==========================================
+ Hits 17353 17645 +292
- Misses 12285 12464 +179
+ Partials 829 826 -3 ☔ View full report in Codecov by Sentry. |
adrianlizarraga
added a commit
to microsoft/onnxruntime
that referenced
this pull request
Apr 15, 2024
justinchuby
added
the
review needed: operators approvers
adrianlizarraga
added a commit
to microsoft/onnxruntime
that referenced
this pull request
Apr 17, 2024
### Description - Adds a patch that fixes a shape inference bug that caused a segfault: onnx/onnx#6080 - Fix documentation describing why QLinearMatMul tests are currently being skipped. ### Motivation and Context The [PR for integrating with ONNX 1.16.0](#19745) disabled various python quantization tests due to a shape inference bug. This PR applies the ONNX fix as a patch. We still can't enable the tests because some of our CIs pip install onnx-1.16.0, which doesn't include the fix.
xadupre
approved these changes
Apr 23, 2024
cjvolzka
pushed a commit
that referenced
this pull request
Apr 29, 2024
Add missing `hasInputShape` condition in shape-inference for DequantizeLinear ... strangely missing in last two versions, but present in earlier version. Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> (cherry picked from commit 5ecc0a9)
Merged
cjvolzka
pushed a commit
that referenced
this pull request
Apr 29, 2024
Add missing `hasInputShape` condition in shape-inference for DequantizeLinear ... strangely missing in last two versions, but present in earlier version. Signed-off-by: G. Ramalingam <grama@microsoft.com> (cherry picked from commit 5ecc0a9)
isdanni
pushed a commit
to isdanni/onnx
that referenced
this pull request
May 6, 2024
Add missing `hasInputShape` condition in shape-inference for DequantizeLinear ... strangely missing in last two versions, but present in earlier version. Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: isdanni <leedanni@gmail.com>
TedThemistokleous
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
May 7, 2024
### Description - Adds a patch that fixes a shape inference bug that caused a segfault: onnx/onnx#6080 - Fix documentation describing why QLinearMatMul tests are currently being skipped. ### Motivation and Context The [PR for integrating with ONNX 1.16.0](microsoft#19745) disabled various python quantization tests due to a shape inference bug. This PR applies the ONNX fix as a patch. We still can't enable the tests because some of our CIs pip install onnx-1.16.0, which doesn't include the fix.
cjvolzka
added a commit
that referenced
this pull request
May 9, 2024
### Description
Check-pick commits from `main` into `rel-1.16.1` branch
### Motivation and Context
Fix 1.16.0 issues and enabled 1.16.1 builds by cherry-picking the
following PRs from `main` into the `1.16.1` branch
* Fixes since 1.16.0 release
* #6049
* #6048
* #6080
* #6122
* Update CI and Build to enable 1.16.1 builds
* #6106
* #6129
* #6075
* #6117
---------
Co-authored-by: liqun Fu <liqfu@microsoft.com>
Co-authored-by: G. Ramalingam <grama@microsoft.com>
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
gramalingam
added a commit
to gramalingam/onnx
that referenced
this pull request
Jun 6, 2024
Add missing `hasInputShape` condition in shape-inference for DequantizeLinear ... strangely missing in last two versions, but present in earlier version. Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Jul 20, 2024
Add missing `hasInputShape` condition in shape-inference for DequantizeLinear ... strangely missing in last two versions, but present in earlier version. Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
hasInputShapecondition in shape-inference for DequantizeLinear ... strangely missing in last two versions, but present in earlier version.