Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LightGBM Version 4.0.0 changes #632

Closed
ksaur opened this issue Jul 16, 2023 · 2 comments
Closed

LightGBM Version 4.0.0 changes #632

ksaur opened this issue Jul 16, 2023 · 2 comments

Comments

@ksaur
Copy link
Contributor

ksaur commented Jul 16, 2023

LGBM 4.0.0 was released 3 days ago and they added an underscore to many things. Ex: FEATURE_IMPORTANCE_TYPE_MAPPER becomes _FEATURE_IMPORTANCE_TYPE_MAPPER. See microsoft/LightGBM#5654

I think this means that onnxmltools needs to update LightGbm.py: _LIB, FEATURE_IMPORTANCE_TYPE_MAPPER, _safe_call, ....
@ksaur ksaur mentioned this issue Jul 16, 2023
Closed
@xadupre
Copy link
Collaborator

xadupre commented Jul 27, 2023

Thanks for reporting it. I'll look into that soon.

This was referenced Jul 28, 2023
Merged
Closed
@xadupre
Copy link
Collaborator

xadupre commented Aug 1, 2023

PR #634 was merged.

@xadupre xadupre closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksaur @xadupre