-
-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.4.2: build fails #450
Comments
This is because of link-time optimizations - a function which indeed does dereference a null pointer gets analyzed in a context outside of doctest.cpp and the silencing of the warning no longer works. However, that null pointer dereference cannot be triggered by a normal code path when doctest is disabled entirely in the project, which is the case of the I'll fix this tomorrow, thanks for reporting - will think of a better solution. I wonder if the problem would go away if you add I also wonder why this problem popped up just now - what was the previous doctest version you used? The same problem should have been there as well with the same GCC version... |
wouldn't this work? i'm running into this problem attempting to package doctest 2.4.2 for fedora core: https://kojipkgs.fedoraproject.org//work/tasks/4860/57554860/build.log |
@dankamongmen I guess that's a good enough solution - did you try it? Does it work? It would be hard for me to reproduce this locally... Let me know, and I'll release |
It solved my issues on Fedora, though on my Debian Unstable machine, I'm seeing:
though this seems to be unrelated to my change (i see it on a fresh checkout). haven't dug into this yet. |
@dankamongmen can you change this in MESSAGE(
"Unable to run test: need "+std::to_string(nb_procs) + " procs"
+ " but program launched with only "+std::to_string(doctest::mpi_world_nb_procs()) + "."
); to this: MESSAGE(
"Unable to run test: need ", std::to_string(nb_procs), " procs",
" but program launched with only ", std::to_string(doctest::mpi_world_nb_procs()), "."
); and let me know if it fixes the problem? I recently reworked the logging macros from using EDIT: nevermind, I tested this locally - will push the fixes now. |
yep, it works. i've got a PR if you want one |
@dankamongmen I just pushed the fixes from my local machine & released |
Just tested 2.4.3 and it works now :) Thx
|
gcc version 11.0.0 20201204.
Sourrce code configure optios:
and build fails:
The text was updated successfully, but these errors were encountered: