Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake's CMP0077 policy if available #363

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Use CMake's CMP0077 policy if available #363

merged 1 commit into from
Apr 29, 2020

Conversation

thelink2012
Copy link
Contributor

Description

Using the project as an add_subdirectory (and setting options with set before doing so) produces an warning regarding policy CMP0077.

This happens because the behavior of using set on variables which will be cached (by option) has changed in CMake 3.12. Before, the value set would be unset, and now the value set is honored.

The project should have CMP0077 set to NEW to ensure it understands this change (the old behaviour is deprecated and may be removed in the future). Doing this outside doctest tree (i.e. the tree that performs add_subdirectory on it) has no effect.

GitHub Issues

Didn't find it necessary. The change is minimal and any necessary discussion can take place in the PR.

@thelink2012 thelink2012 changed the title Use CMP0077 policy if available Use CMake's CMP0077 policy if available Apr 29, 2020
@onqtam
Copy link
Member

onqtam commented Apr 29, 2020

Thanks!

@onqtam onqtam merged commit a0f0a13 into doctest:dev Apr 29, 2020
onqtam pushed a commit that referenced this pull request May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants