Use CMake's CMP0077 policy if available #363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the project as an
add_subdirectory
(and setting options withset
before doing so) produces an warning regarding policy CMP0077.This happens because the behavior of using
set
on variables which will be cached (byoption
) has changed in CMake 3.12. Before, the value set would be unset, and now the value set is honored.The project should have
CMP0077
set toNEW
to ensure it understands this change (the old behaviour is deprecated and may be removed in the future). Doing this outside doctest tree (i.e. the tree that performsadd_subdirectory
on it) has no effect.GitHub Issues
Didn't find it necessary. The change is minimal and any necessary discussion can take place in the PR.