Skip to content

Commit

Permalink
Use two dashes for test.timeout argument.
Browse files Browse the repository at this point in the history
Alternate flag libraries such as github.com/spf13/pflag add support for
shorthand flags. This causes "-test.timeout" to be interpreted as the
shorthand flag "t" rather than the longhand flag "test.timeout".
Using two dashes avoids this issue.
  • Loading branch information
ixdy committed Apr 24, 2015
1 parent dbb5c6c commit 7cceec8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ginkgo/testrunner/test_runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ func (t *TestRunner) runParallelGinkgoSuite() RunResult {
}

func (t *TestRunner) cmd(ginkgoArgs []string, stream io.Writer, node int) *exec.Cmd {
args := []string{"-test.timeout=24h"}
args := []string{"--test.timeout=24h"}
if t.cover {
coverprofile := "--test.coverprofile=" + t.Suite.PackageName + ".coverprofile"
if t.numCPU > 1 {
Expand Down

0 comments on commit 7cceec8

Please sign in to comment.