Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getPackageImportPath assumes src only exists once in PWD #14

Closed
dcapwell opened this issue Nov 19, 2013 · 2 comments
Closed

getPackageImportPath assumes src only exists once in PWD #14

dcapwell opened this issue Nov 19, 2013 · 2 comments

Comments

@dcapwell
Copy link 

$ ginkgo generate gossh
panic: Couldn't identify package import path

goroutine 1 [running]:
main.getPackageImportPath(0x210285088, 0x5)
        $HOME/src/github/gopath/src/github.com/onsi/ginkgo/ginkgo/templates.go:130 +0x110
main.generateSpec(0x7fff5fbff408, 0x5)

I put all my github code under $HOME/src/github. Because of go's directory requirements, I get around this by adding gopath under github, and have a src there. So, if you look at my PWD, I have two src dirs.
@dcapwell dcapwell mentioned this issue Nov 19, 2013
Closed
@onsi
Copy link
Owner

onsi commented Nov 19, 2013

I've fixed this on master now. It basically does what your PR suggests but adds a bit more commentary/logging instead of panicking. Thanks!

@onsi onsi closed this as completed Nov 19, 2013
@dcapwell
Copy link
Author

Cool, Ill try to test latest code tonight and verify the change works.

xjh1996 pushed a commit to xjh1996/ginkgo that referenced this issue Jan 12, 2021
@LiuqingLiao
add auth demo (onsi#14)
6f66feb 
* bugfix: loadconfig (onsi#17)

feature: add tenant to request

* WIP:add auth demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onsi @dcapwell