Is it possible to hook the mock lib of testify into ginkgo?

[AlexLuya]

I think the mocking style of testify(https://github.com/stretchr/testify) is more nature than gomock,is it possible to hook it's mock lib into ginkgo?

[onsi]

It looks like testify uses (*testing.T) directly instead of an interface (which gomock does). Ginkgo can provide such frameworks with a Fail function that one can wrap in such a way to satisfy most interfaces (this is how we support go mock), but *testing.T refers to a concrete type and passing in the testing.T for the test that Ginkgo runs in would cause the entire suite to fail should one of your mock assertions fail...

So: step one would be to get a pull request into testify that replaces *testing.T with an interface (not hard from an implementation perspective, but it does add a layer of obfuscation into testify?) After that I should be able to cook up a testify module much like the go mock module.

[AlexLuya]

I have tried several mocking frameworks,such as gomock,mock of testify, mogo(https://github.com/gcurtis/mogo) that is quite like testify mock,and mock4go (https://github.com/jvshahid/mock4go).I found mock4go's approach is quite concise.So is it possible to integrate it to ginkgo?The last updates of mock4go has happened 7 month ago,but it doesn't matter,I will contact author,if he is busy or wants to quit, I can provide some help.

[onsi]

Hey @AlexLuya:

mogo looks like a slightly cleaner implementation than testify and would fit right into Ginkgo. One could even right a simple Gomega matcher to wrap calling the Verify method and asserting there is no error into a one-liner.

mock4go seems much more elaborate. in principal It Could Just Work... though it sounds like you have to run tests using mock4go which, I imagine, does the instrumentation then calls down to go test -- I don't know if it'll let you pass flags down to go test so you might lose some of ginkgo's more advanced command line stuff.

Did you try using mock4go in a ginkgo suite? If you give it a try and it doesn't work I'd be happy to take a look.

If you want my opinion:

I generally prefer avoiding mocks/stubs entirely by writing my own fakes and injecting them into my objects under test. mogo sounds like a simple enough wrapper that allows you to write fakes with (a little) less code. IMHO mock4go goes a bit too far by instrumenting your production code. it probably doesn't break things.... but it is amending your code under the hood!

[AlexLuya]

I agree with this:

"mock4go goes a bit too far by instrumenting your production code. it
probably /doesn't/ break things.... but it /is/ amending your code under

the hood!"

And have report to author: jvshahid/mock4go#2

I will to try mogo with ginko.

On 12/24/2013 04:18 AM, Onsi Fakhouri wrote:

Hey @AlexLuya https://github.com/AlexLuya:

mogo looks like a slightly cleaner implementation than testify and
would fit right into Ginkgo. One could even right a simple Gomega
matcher to wrap calling the |Verify| method and asserting there is no
error into a one-liner.

mock4go seems much more elaborate. in principal It Could Just Work...
though it sounds like you have to run tests using |mock4go| which, I
imagine, does the instrumentation then calls down to |go test| -- I
don't know if it'll let you pass flags down to |go test| so you might
lose some of |ginkgo|'s more advanced command line stuff.

Did you try using |mock4go| in a ginkgo suite? If you give it a try
and it doesn't work I'd be happy to take a look.

If you want my opinion:

I generally prefer avoiding mocks/stubs entirely by writing my own
fakes and injecting them into my objects under test. mogo sounds like
a simple enough wrapper that allows you to write fakes with (a little)
less code. IMHO mock4go goes a bit too far by instrumenting your
production code. it probably /doesn't/ break things.... but it /is/
amending your code under the hood!

—
Reply to this email directly or view it on GitHub
#17 (comment).

[onsi]

This is now possible!

See
http://onsi.github.io/ginkgo/#using_other_matcher_libraries

for an example of using testify with Ginkgo.

[wolfgangmeyers]

@onsi correction on the link - http://onsi.github.io/ginkgo/#using-other-matcher-libraries