-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teamcity reporter: output location of test failure #626
teamcity reporter: output location of test failure #626
Conversation
4eb47f3
to
331039d
Compare
Thank you @dlipovetsky. I don't have much context on the teamcity reporter, and it has only been changed once in the past few years - by @manosnoam. So I'll leave this a few days in case @manosnoam has any feedback, since sometimes changes to formats can sometimes break other teams. |
Hi @dlipovetsky, Can you also give an output (or screenshot) example from TeamCity ? |
Hi @manosnoam! Thanks for reviewing, and for implementing the TeamCity reporter 😄
For comparison, the JUnit reporter outputs both locations when a test fails.
I'll try to get one that doesn't leak any internal information 😄 . |
Thanks for the review @blgm! You make a good point. The TeamCity message contains two attributes, For example: Before:
After
I only expect TeamCity itself to parse the service messages. I don't believe TeamCity parses the contents of |
…finition Previously, only the test definition was output. When a test fails, the location of the failure is important to know, especially for complex tests. Signed-off-by: Daniel Lipovetsky <dlipovetsky@d2iq.com>
331039d
to
aaadeac
Compare
Rebased. |
@manosnoam Your thoughts? |
Looks good to me. A side note: For example, it has happened to me that an assertion failed inside an ginkgo/reporters/junit_reporter_test.go Line 192 in 3cfa02d
But then the stacktrace did not refer to that exact line of assertion, but only to the first line of the block: ginkgo/reporters/junit_reporter_test.go Line 183 in 3cfa02d
In this case it is unknown what assertion actually broke the test... |
@dlipovetsky thank you for this contribution! @manosnoam thank you for reviewing! |
Fixes #623