Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if a spec is run before returning SpecSummary #645

Merged
merged 1 commit into from
Mar 15, 2020
Merged

check if a spec is run before returning SpecSummary #645

merged 1 commit into from
Mar 15, 2020

Conversation

p0lyn0mial
Copy link
Contributor

This pull prevents a null pointer exception by checking if a spec is run before returning its summary.

The issue might occur when someone simply executes ginkgo.CurrentGinkgoTestDescription()

@p0lyn0mial p0lyn0mial requested a review from onsi February 14, 2020 14:38
@blgm blgm merged commit 8850000 into onsi:master Mar 15, 2020
@blgm
Copy link
Collaborator

blgm commented Mar 15, 2020

Looks good. Thank you @p0lyn0mial!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onsi onsi Awaiting requested review from onsi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0lyn0mial @blgm