Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Number of card id's != total #80

Closed
alotau opened this issue May 20, 2014 · 3 comments
Closed

Number of card id's != total #80

alotau opened this issue May 20, 2014 · 3 comments
Assignees
Labels
Milestone

Comments

@alotau
Copy link

alotau commented May 20, 2014

Did something change in the API? Currently when fetching cards by set like:

http://api.mtgdb.info/sets/10E

the value for 'total' is different than the number of cardIds that are returned.

Is this an issue with tokens being included in the 'total' but not having a cardId?

@ontehfritz
Copy link
Owner

Yes! I still need to get into this it does have something to do with promo and token cards (and some unknowns I have to look into). I was using the cardId for counts, but when using paging etc it was messing it up royally.

#75

What the plan is to get all the funtionality opendb stuff and deck builder complete, the api's first priority is mtgdb.info fronted. Once all that is built, then it is time to hammer the quality in from data to code before anything else is built. So it will get there. Bare with me!

@ontehfritz ontehfritz added this to the 0.2 milestone May 20, 2014
@ontehfritz ontehfritz self-assigned this May 20, 2014
@alotau
Copy link
Author

alotau commented May 20, 2014

I'm not too worried about it, just noticed when one of my junit tests started failing. Never used unit testing before... quite handy!

@ontehfritz
Copy link
Owner

It gets published counts now so it, its all good. I will close this! But promos and tokens will be dealt with.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants