Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] name:xx missing in transportation_name #419

Closed
ZeLonewolf opened this issue Dec 20, 2022 · 2 comments
Closed

[BUG] name:xx missing in transportation_name #419

ZeLonewolf opened this issue Dec 20, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@ZeLonewolf
Copy link
Contributor

ZeLonewolf commented Dec 20, 2022

Unblocks osm-americana/openstreetmap-americana#618
CC @zstadler

Internationalized name:xx names are missing from roads in the transportation_name layer.

The following object show internationalized names in omt-tools:
image

Same location in my planetiler server (link)
image

@msbarry
Copy link
Contributor

msbarry commented Jan 2, 2023

Good catch, looks like transporation_name layer does include all translations https://github.com/openmaptiles/openmaptiles/blob/c4d86d44a661146c273b97ac294db2381a570b2c/layers/transportation_name/transportation_name.yaml#L107 - can you transfer this to https://github.com/openmaptiles/planetiler-openmaptiles so we can fix over there?

I think the fix would just involve changing OmtLanguageUtils.getNamesWithoutTranslations to OmtLanguageUtils.getNames in TransportationName.java

@ZeLonewolf
Copy link
Contributor Author

Done! Moved to openmaptiles/planetiler-openmaptiles#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants