1166 add mimetype info to controllers #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to return a correct 406 response we need to remove mime constraints from routes where we do not actually use them for routing. This currently holds true for all routes.
This includes Logics, Repositories, Ontologies, Sentences, Symbols and Mappings.
| @@ -0,0 +1 @@ | |||
| Mime::Type.register 'application/rdf+xml', :rdf | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
0robustus1
force-pushed
the
1166-add_mimetype_info_to_controllers
branch
2 times, most recently
from
47ea3c3
to
23f0ab4
Compare
| ] | ||
| ] do | ||
| accept 'text/html' | ||
| accept 'text/plain' |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Add the mime-type information (respond_to) to the specific controllers. This will ensure that they will return a 406 if no acceptable mime-type was requested.
0robustus1
force-pushed
the
1166-add_mimetype_info_to_controllers
branch
from
a5b62a5
to
a6204b6
Compare
| ] | ||
| ] do | ||
| accept 'text/html' | ||
| accept 'text/plain' |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
👍 |
0robustus1
added a commit
that referenced
this pull request
Mar 9, 2015
…ollers 1166 add mimetype info to controllers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reduced that to the API relevant controllers, as i'm not entirely sure what all controllers should actually respond to. So this will close #1166.