1246 use api controllers #1248
1246 use api controllers #1248
Conversation
| def show | ||
| super do |format| | ||
| format.xml do | ||
| render :show, content_type: 'application/rdf+xml' |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
0robustus1
force-pushed
the
1246-use_api_controllers
branch
3 times, most recently
from
e444fc0
to
2d940e3
Compare
| @@ -10,14 +10,29 @@ | |||
| # as per Loc/Id definition | |||
|
|
|||
| # Special (/ref-based) Loc/Id routes | |||
| specified_get '/ref/:reference/:repository_id/*locid' => 'api/v1/ontology_versions#show', | |||
| as: :ontology_iri_versioned, | |||
| constraints: [ | |||
There was a problem hiding this comment.
Align the elements of a hash literal if they span more than one line.
0robustus1
force-pushed
the
1246-use_api_controllers
branch
from
2d940e3
to
d6bcab2
Compare
0robustus1
force-pushed
the
1246-use_api_controllers
branch
3 times, most recently
from
122d235
to
2f6a526
Compare
|
The seeds fail at the proof statuses step: Hets can't retrieve the proof statuses file from the running ontohub instance. ❯ wget --header='Accept: */*; q=0.1, text/plain' --no-check-certificate -O - http://localhost:3000/ref/1/meta/proof_statuses 2> /dev/null
{"iri":"localhost:3000/ref/1/meta/proof_statuses","evaluation_state":"failed","number":1,"commit_oid":"0ae3c897ea23e8729f681c147d6fd19006c0c879","basepath":"proof_statuses","file_extension":".owl","ontology":{"iri":"localhost:3000/meta/proof_statuses","name":"Proof_statuses"}}(The wget call is copied from the Hets source) |
|
http://ontohub.dev/meta should open the file browser, but it shows the repository show-page. |
|
Jep that is correct. |
0robustus1
force-pushed
the
1246-use_api_controllers
branch
from
515444c
to
66b0060
Compare
|
http://ontohub.dev/meta should now again show the file browser. |
|
Yes, it's fixed. I'm reviewing the last commits right now. |
|
I'm not sure if this is a problem with curl, specroutes, rails routing or I got something wrong and this is a request for whom no support is intended: The same goes for http://ontohub.dev/default/partial_order//strict_partial_order//elem |
|
Jep, when i adjusted the routes for the MIME-type override i forgot to set the id in the router-constraint. So it is actually an 'issue' in rails routing ;) |
|
👍 after merging #1247 and rebasing staging |
We use ActiveModel::Serializers instead and this does not require particular views.
This is for the newly implemented reroutes feature, which allows rerouting to a different controller based on mime-type. Additionally this gets us the allstar feature and a breaking reversal of standard allstar handling (it is deactivated by default).
This will actually support a show on ontology-versions via json.
It seems that the parse-call was done before an ontology-version was created (which seems crazy to me). However using do_not_parse and manually calling parse works.
0robustus1
force-pushed
the
1246-use_api_controllers
branch
from
f05e313
to
772288c
Compare
Shall close #1246. My first idea (laid out in the issue-description) was not really appropriate, as we would've
needed to create multiple definitions (at least one for every api-version and one for the frontend) in order to provide outer grouping. Instead we'll do 'inner grouping' by extending the DSL in order to reroute
on mime-type (or arbitrary header, which is not in use yet) to another controller, in this case the api provided controller instead of the default frontend controller.
Additionally this moves every api-action into the appropriate api controller. This is based on the 1233-json_for_model_resources branch (which is in turn based on 1166-add_mimetype_info_to_controllers).
So please obey the following review-order: