forked from ontoportal/goo
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Support multilingual - Add read multiple language #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haddadzineddine
changed the title
if requested_lang = 'all' return all
Feature/language return all
Apr 23, 2023
haddadzineddine
changed the title
Feature/language return all
Feature | Language return all
Apr 23, 2023
syphax-bouazzouni
requested changes
Apr 28, 2023
syphax-bouazzouni
changed the title
Feature | Language return all
Feature: Support multilingual - Add read multiple language
Apr 28, 2023
Change the language key to lowercase |
Added:
|
syphax-bouazzouni
added a commit
that referenced
this pull request
Sep 5, 2023
syphax-bouazzouni
added a commit
that referenced
this pull request
Dec 4, 2023
* Merge pull request #24 from ontoportal-lirmm/feature/support-multilingual-read-one-language-from-request-parameter Feature : Support multilingual - Phase 1 - Read one language * Merge branch pull request #32 from feature/language-return-all * group unmapped properties by lang * Feature: group unmapped properties by language (#38) * group unmapped properties by lang * downcase language keys of unmapped properties --------- Co-authored-by: Syphax bouazzouni <gs_bouazzouni@esi.dz> * Feature: Support multi lingual - add show_language argument to the attributes getters (#39) * update define_method * update solution mapper * update get_preload_value * Merge pull request #40 from ontoportal-lirmm/support-muli-lang-part-02 Fix: save_model_values if unmmaped condition * Merge pull request #41 from ontoportal-lirmm/support-muli-lang-part-02 Feature: Refactor and fix the Language filter method * Merge pull request #42 from ontoportal-lirmm/feature/support-multi-langual-search Feature: Make map_attribute support showing all languages - Support multi language search --------- Co-authored-by: HADDAD Zineddine <hz_haddad@esi.dz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new branch called language_return_all that returns all existing result when the requested language value is set to "all". This feature was implemented based on the request described in issue agroportal/project-management#307
Changes Made / Todos
Added new branch called language_return_all .
Implemented logic to return all existing result when the requested language value is set to "all".
Set @language to the requested language [ Feature: return requested languages in @language - part 2 - multiple langugaes ontologies_linked_data#80 ]
Support select multilanguages 688ec5e
Show the values in all languages with their corresponding language. [ Multilingual support agroportal/project-management#307 ]
In @language return the available languages for the result not the requested languages ontoportal-lirmm/ontologies_linked_data@fad47b4
Make it works for all attribues not only
synonyms
andprefLabel
Fix tests
Screenshots
use case : localhost:9393/ontologies/INRAETHES/classes
requested_lang = all
requested_lang = fr
requested_lang = en
requested_lang = fr,en
Resources & Informations
For the
requested_lang = all
, we need to show the values in all languages but also their corresponding language, like thisFor the case none languages :
So for your use case of synonyms, it needs to be like this:
The global issue that describes this is here: agroportal/project-management#307
Reviewers
@syphax-bouazzouni