Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Multilingual Support - Add search and languages serialization #199

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented May 6, 2024

Require

Context

This PR, implements mostly two things:

See the added units tests, for examples.

Changes

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 71.55812% with 345 lines in your changes are missing coverage. Please review.

Project coverage is 78.10%. Comparing base (299a01c) to head (fc48343).
Report is 116 commits behind head on develop.

Files Patch % Lines
...ion_process/operations/submission_rdf_generator.rb 55.33% 184 Missing ⚠️
...ubmission_process/operations/submission_indexer.rb 60.97% 48 Missing ⚠️
lib/ontologies_linked_data/utils/notifications.rb 61.11% 28 Missing ⚠️
lib/ontologies_linked_data/serializers/json.rb 65.71% 12 Missing ⚠️
...ocess/operations/submission_mertrics_calculator.rb 83.33% 12 Missing ⚠️
lib/ontologies_linked_data/models/class.rb 83.07% 11 Missing ⚠️
lib/ontologies_linked_data/metrics/metrics.rb 33.33% 8 Missing ⚠️
...rocess/operations/submission_properties_indexer.rb 82.60% 8 Missing ⚠️
...tologies_linked_data/models/ontology_submission.rb 64.28% 5 Missing ⚠️
...ervices/submission_process/submission_processor.rb 91.93% 5 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #199      +/-   ##
===========================================
- Coverage    80.80%   78.10%   -2.71%     
===========================================
  Files           63       74      +11     
  Lines         4907     5370     +463     
===========================================
+ Hits          3965     4194     +229     
- Misses         942     1176     +234     
Flag Coverage Δ
unittests 78.10% <71.55%> (-2.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syphax-bouazzouni syphax-bouazzouni marked this pull request as ready for review May 6, 2024 12:13
@syphax-bouazzouni syphax-bouazzouni changed the title Feature: Multilingual Support Feature: Multilingual Support - Add search and languages serialization May 6, 2024
@alexskr alexskr changed the base branch from develop to Feature/multilingual_support_add_search_and_languages_serialization May 8, 2024 01:20
@alexskr alexskr changed the base branch from Feature/multilingual_support_add_search_and_languages_serialization to feature/multilingual-support-add-search-and-languages-serialization May 8, 2024 03:57
@alexskr alexskr merged commit f6764a8 into ncbo:feature/multilingual-support-add-search-and-languages-serialization May 8, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants