Merge SKOS features and upstream #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphax-bouazzouni
force-pushed
the
development
branch
from
c9c1a6c
to
b410981
Compare
syphax-bouazzouni
force-pushed
the
development
branch
from
6992eac
to
d51925f
Compare
| module Concerns | ||
| module Concept | ||
| module Sort | ||
| module ClassMethods |
There was a problem hiding this comment.
TDOD: do a pull request for this refactored module
| @@ -889,7 +888,7 @@ def self.mappings_ont_build_query(class_id, page, size, sub1, sub2) | |||
| #STRSTARTS is used to not count older graphs | |||
| #no need since now we delete older graphs | |||
|
|
|||
| filter += "\nFILTER (!STRSTARTS(str(?g),'#{ont_id}') || (?source = 'SAME_URI')" | |||
| filter += "\nFILTER (!STRSTARTS(str(?g),'#{ont_id}')" | |||
There was a problem hiding this comment.
test if this works well
| # re-generate metrics file | ||
| submission.generate_metrics_file2(cls_metrics[:classes], indiv_count, prop_count, cls_metrics[:maxDepth]) | ||
| submission.generate_metrics_file(cls_metrics[:classes], indiv_count, prop_count) |
There was a problem hiding this comment.
discuss with bioportal about this generate_metrics_file2 (method) for now stay with the old one
| #cause it has not the subproperty added | ||
| assert_equal 474, metrics.classesWithNoDefinition | ||
| assert_equal 0, metrics.classesWithMoreThan25Children | ||
| assert_equal 0, metrics.maxChildCount | ||
| assert_equal 0, metrics.averageChildCount | ||
|
|
||
| assert_equal 0, metrics.maxDepth |
There was a problem hiding this comment.
investigate this change
This reverts commit 79c9cd4.
syphax-bouazzouni
force-pushed
the
development
branch
from
d51925f
to
d43c850
Compare
This was referenced Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
SKOS scheme (f5b9f00)
SKOS collection (b410981)
SKOS roots, tree, and concept children filtered by collection and scheme
SKOS XL (79c9cd4)
Get the correct type for SKOS concepts (i.e skos:Concept, not owl:Class) (cfe3342)
Add tests for SKOS submissions, schemes, collections, skos_xl
Add SKOS links to the ontology model (3da053d)
Mappings (b567855)
Add dates attribute to Class/Concept module (29d8834)
Merge to upstream v5.23.1 (ba0b72b)
Extract concept sort module
Related branches