Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keypressobservers #13

Closed
rossengeorgiev opened this issue Jul 12, 2015 · 2 comments
Closed

Fix keypressobservers #13

rossengeorgiev opened this issue Jul 12, 2015 · 2 comments

Comments

@rossengeorgiev
Copy link

This repo looks out of data, but I am openning the issue anyway. The implementation of KeypressObservers is not cross-browser compatible. The code is located in picker-angular.js and here is a fix.

KeypressObservers = [];
jQuery(document).on('keypress', function(e){
    for (var N = 0; N < KeypressObservers.length; N++)
        KeypressObservers[N](e.which || e.keyCode);
});
@onur
Copy link
Owner

onur commented Jul 12, 2015

Hi. Thanks for reporthing. But I am not sure I understand the issue and your fix.

This project is not using angular. It's using backbone.js and I am using backbone events.

@rossengeorgiev
Copy link
Author

Right. My mistake, I came here from http://dotapicker.com/counterpick.php, but apparently that's not the same project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants