Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-focus on search box after clicking portrait #3

Open
herrjakob opened this issue May 22, 2014 · 3 comments
Open

Auto-focus on search box after clicking portrait #3

herrjakob opened this issue May 22, 2014 · 3 comments

Comments

@herrjakob
Copy link

This issue mainly affects (mobile) devices with smaller screens: If you click a hero portrait, the search box is automatically selected/focused. This causes the screen to jump up to it and you have to scroll all the way down to where you have been before.

@onur
Copy link
Owner

onur commented May 22, 2014

Thanks for reporting, but this app is not designed for mobile devices.

I believe focus on search box after clicking a hero is a nice feature. Users can keep adding heroes continuously. They don't need to click a hero and click search box again.

If this issue is crucial for you, then you can make your own fork and remove focus in index.html (line 303). Or you can just download gh-pages branch and remove focus line in your local file.

@onur
Copy link
Owner

onur commented May 29, 2014

I am closing this issue since I didn't hear from you and I have no plan to change how it works for now.

@onur onur closed this as completed May 29, 2014
@onur
Copy link
Owner

onur commented Aug 3, 2014

I had a chance to test this app in a mobile browser and this issue is need to be fixed even it is not designed for mobile browsers. I am reopening this issue, and hopefully will fix it when I have time.

@onur onur reopened this Aug 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants