Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errorCallback is not invoked when locateByIP fails #6

Closed
kallelat opened this issue Dec 12, 2014 · 2 comments
Closed

errorCallback is not invoked when locateByIP fails #6

kallelat opened this issue Dec 12, 2014 · 2 comments
Labels
bug stability

Comments

@kallelat
Copy link

I have been testing with freegeoip; as it has been down quite a lot lately, I tried to add errorCallback to catch those situations but didn't help.
@onury onury added the bug label Dec 12, 2014
@onury
Copy link
Owner

onury commented Dec 12, 2014

Hi, thanks for the report. FreeGeoIP service seems to be unstable but this is still a bug. Geolocator should correctly handle load errors and invoke the errorCallback.

This is fixed in version 1.2.4.
Please check it out and let me know if it works for you, too.

@onury onury closed this as completed Dec 13, 2014
@kallelat
Copy link
Author

Perfect, thank you, I will check it out soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug stability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kallelat @onury