Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined properties #15

Closed
chaud opened this issue Aug 25, 2020 · 0 comments · Fixed by #16
Closed

Undefined properties #15

chaud opened this issue Aug 25, 2020 · 0 comments · Fixed by #16

Comments

@chaud
Copy link
Contributor

chaud commented Aug 25, 2020

Guessing these were renamed or typoed.

( ! ) Notice: Undefined property: TippingOverConfiguration::$mLateCategoryFilter in extensions/TippingOver/includes/TippingOverConfiguration.php on line 423
Call Stack
#	Time	Memory	Function	Location
8	0.1970	8122040	TippingOverConfiguration->__construct( )	.../WikiTooltips.php:144
9	0.1970	8122616	TippingOverConfiguration->validate( )	.../TippingOverConfiguration.php:289

( ! ) Notice: Undefined property: TippingOverConfiguration::$mEarlyCategoryFilter in extensions/TippingOver/includes/TippingOverConfiguration.php on line 462
Call Stack
#	Time	Memory	Function	Location
8	0.1970	8122040	TippingOverConfiguration->__construct( )	.../WikiTooltips.php:144
9	0.1970	8122616	TippingOverConfiguration->validate( )	.../TippingOverConfiguration.php:289

( ! ) Notice: Undefined property: TippingOverConfiguration::$mExistsCheck in extensions/TippingOver/includes/TippingOverConfiguration.php on line 464
Call Stack
#	Time	Memory	Function	Location
8	0.1970	8122040	TippingOverConfiguration->__construct( )	.../WikiTooltips.php:144
9	0.1970	8122616	TippingOverConfiguration->validate( )	.../TippingOverConfiguration.php:289

( ! ) Notice: Undefined property: TippingOverConfiguration::$enableOnImageLinks in extensions/TippingOver/includes/WikiTooltips.php on line 150
Call Stack
#	Time	Memory	Function	Location
6	0.1968	8114480	Hooks::callHook( )	.../Hooks.php:202
7	0.1969	8118456	WikiTooltips::initializeHooksAndModule( )	.../Hooks.php:174
@chaud chaud mentioned this issue Sep 14, 2020
Merged
mszabo-wikia added a commit to Wikia/TippingOver that referenced this issue Jun 2, 2022
@mszabo-wikia
Follow-up 7a10cd7: Handle LinkTarget in followRedirect()
b1923d8 
followRedirect() may be called with a LinkTarget implementation
such as TitleValue rather than a full Title, so ensure we cast
it to Title first before attempting to call canExist().

Avoid the following:

```
 Error from line 52 of /extensions/TippingOver/includes/WikiTooltipsCore.php: Call to undefined method TitleValue::canExist()
	#0 /extensions/TippingOver/includes/WikiTooltips.php(495): WikiTooltipsCore::followRedirect(TitleValue)
	#1 /extensions/TippingOver/includes/WikiTooltips.php(614): WikiTooltips::runEarlyTooltipChecks(TitleValue)
	#2 /extensions/TippingOver/includes/WikiTooltips.php(647): WikiTooltips::maybeAttachTooltip(TitleValue, array)
	#3 /includes/HookContainer/HookContainer.php(338): WikiTooltips::linkTooltipRender(MediaWiki\Linker\LinkRenderer, TitleValue, boolean, HtmlArmor, array, NULL)
	#4 /includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
	#5 /includes/HookContainer/HookRunner.php(2031): MediaWiki\HookContainer\HookContainer->run(string, array)
	#6 /includes/linker/LinkRenderer.php(321): MediaWiki\HookContainer\HookRunner->onHtmlPageLinkRendererEnd(MediaWiki\Linker\LinkRenderer, TitleValue, boolean, HtmlArmor, array, NULL)
	#7 /includes/linker/LinkRenderer.php(217): MediaWiki\Linker\LinkRenderer->buildAElement(TitleValue, HtmlArmor, array, boolean)
	#8 /includes/linker/LinkRenderer.php(248): MediaWiki\Linker\LinkRenderer->makePreloadedLink(TitleValue, HtmlArmor, string, array, array)
	#9 /includes/linker/LinkRenderer.php(165): MediaWiki\Linker\LinkRenderer->makeKnownLink(TitleValue, HtmlArmor, array, array)
	#10 /includes/Linker.php(123): MediaWiki\Linker\LinkRenderer->makeLink(TitleValue, HtmlArmor, array, array)
	oOeyes#11 /includes/Linker.php(1091): Linker::link(TitleValue, string, array)
	oOeyes#12 /includes/Linker.php(1335): Linker::userLink(integer, string)
	oOeyes#13 /includes/actions/pagers/HistoryPager.php(426): Linker::revUserTools(MediaWiki\Revision\RevisionStoreRecord, boolean, boolean)
	oOeyes#14 /includes/actions/pagers/HistoryPager.php(159): HistoryPager->historyLine(stdClass, stdClass, boolean, boolean, boolean)
	oOeyes#15 /includes/pager/IndexPager.php(613): HistoryPager->formatRow(stdClass)
	oOeyes#16 /includes/actions/HistoryAction.php(319): IndexPager->getBody()
	oOeyes#17 /includes/actions/FormlessAction.php(48): HistoryAction->onView()
	oOeyes#18 /includes/MediaWiki.php(543): FormlessAction->show()
	#19 /includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
	#20 /includes/MediaWiki.php(930): MediaWiki->performRequest()
	#21 /includes/MediaWiki.php(564): MediaWiki->main()
	#22 /index.php(53): MediaWiki->run()
	#23 /index.php(46): wfIndexMain()
	#24 {main}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error spam from variables that don't exist chaud/TippingOver
1 participant
@chaud