Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(filter): allow more types for Equalizer #61

Merged
merged 3 commits into from
Apr 19, 2023
Merged

feat(filter): allow more types for Equalizer #61

merged 3 commits into from
Apr 19, 2023

Conversation

ooliver1
Copy link
Owner

Summary

This allows more types to be passed to Equalizer and Filter.
This has the side effect of adding __slots__ to Equalizer and Filter, since
dataclasses don't support __slots__ in <3.10.

Checklist

  • If code changes were made then they have been tested.
  • I have run task lint to format code and my changes.
  • I have run task pyright and fixed the relevant issues.

@ooliver1 ooliver1 added t: enhancement Type: enhancement - new feature or request p: medium Priority: medium - should be worked on in the near future labels Apr 19, 2023
@ooliver1 ooliver1 enabled auto-merge (squash) April 19, 2023 19:05
@ooliver1 ooliver1 merged commit a3d2596 into master Apr 19, 2023
@ooliver1 ooliver1 deleted the feat/filters-eq-more-types branch April 19, 2023 19:16
@ooliver1 ooliver1 mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p: medium Priority: medium - should be worked on in the near future t: enhancement Type: enhancement - new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ooliver1