Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whatsapp: remove AllEndpoints option #1226

Closed
bassosimone opened this issue Jul 9, 2020 · 2 comments · Fixed by ooni/probe-ios#381 or ooni/probe-android#350
Closed

whatsapp: remove AllEndpoints option #1226

bassosimone opened this issue Jul 9, 2020 · 2 comments · Fixed by ooni/probe-ios#381 or ooni/probe-android#350
Assignees
@bassosimone @lorenzoPrimi
Labels
ooni/probe-desktop ooni/probe-mobile issues related to OONI Probe mobile
Milestone
Sprint 18 - Colomber

Comments

@bassosimone
Copy link
Member

This option increases the false positive rate. If an endpoint is blocked/down and we choose it, then we say that WhatsApp is down when instead it may just be a minor disruption. The Go implementation and the spec have been updated to not mention this option anymore. Using this option on mobile will now trigger a warning.

See ooni/probe-engine#743 (comment)
@bassosimone bassosimone added this to the Sprint 18 - Colomber milestone Jul 9, 2020
@lorenzoPrimi
Copy link

@bassosimone should I also switch to the Go implementation of whatsapp test?

@bassosimone
Copy link
Member Author

@lorenzoPrimi I think it's fine to start removing the option. If you switch to Go now it breaks b/c you don't have the new engine version that also implements WhatsApp.

This was referenced Jul 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

@lorenzoPrimi lorenzoPrimi

Labels
ooni/probe-desktop ooni/probe-mobile issues related to OONI Probe mobile
Projects
None yet
Milestone
Sprint 18 - Colomber
3 participants
@bassosimone @sarathms @lorenzoPrimi