Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL doesn't work on iOS #2578

Closed
sloncocs opened this issue Oct 19, 2023 · 0 comments · Fixed by ooni/probe-ios#546 or ooni/probe-ios#553
Closed

RTL doesn't work on iOS #2578

sloncocs opened this issue Oct 19, 2023 · 0 comments · Fixed by ooni/probe-ios#546 or ooni/probe-ios#553
Assignees
@aanorbel
Labels
bug Something isn't working enhancement improving existing code or new feature funder/otffoss2023-2024 localization ooni/probe-mobile issues related to OONI Probe mobile platform/ios priority/medium triage user feedback requests that have been added to the backlog as a direct result of user feedback or testing ux

Comments

@sloncocs
Copy link

Describe the bug

RTL doesn't work properly on iOS and aligns Arabic text by the left side of the screen

To Reproduce

Set up OONI Probe language to Arabic or Farsi.

Expected behavior

RTL orientation on Android:

Screenshot_20231019_100418
Screenshot_20231019_100444
Screenshot_20231019_100454
Screenshot_20231019_100413

Screenshots

on iOS




IMAGE 2023-10-19 13:15:57
IMAGE 2023-10-19 13:16:02
IMAGE 2023-10-19 13:16:11
IMAGE 2023-10-19 13:16:19

System information (please complete the following information):

  • Device: [e.g., iPhone13]
  • OS: [e.g., iOS16.2]
  • OONI Probe version: [e.g., 3.8.3]

Additional context

Add any other context about the problem here.
@sloncocs sloncocs added bug Something isn't working user feedback requests that have been added to the backlog as a direct result of user feedback or testing triage labels Oct 19, 2023
@aanorbel aanorbel added enhancement improving existing code or new feature ooni/probe-mobile issues related to OONI Probe mobile ux priority/medium platform/ios localization labels Oct 19, 2023
@aanorbel aanorbel mentioned this issue Dec 15, 2023
Merged
aanorbel added a commit to ooni/probe-ios that referenced this issue Dec 18, 2023
@aanorbel
Fix: RTL doesn't work on iOS (#546)
12a2039 
Fixes  ooni/probe#2578

## Proposed Changes

  - Fix indentation for storyboard in onboarding screens

|.|.|.|
|--|--|--|
| ![Simulator Screenshot - iPhone 15 Pro Max - 2023-12-15 at 10 41
40](https://github.com/ooni/probe-ios/assets/17911892/69abd0a3-1e7b-44df-a488-1a402f866268)
| ![Simulator Screenshot - iPhone 15 Pro Max - 2023-12-15 at 10 41
42](https://github.com/ooni/probe-ios/assets/17911892/5d7ec93b-1c17-4d95-89b3-955755502ea5)
| ![Simulator Screenshot - iPhone 15 Pro Max - 2023-12-15 at 10 41
49](https://github.com/ooni/probe-ios/assets/17911892/d726583a-a165-43c8-a11e-872d35a32295)|
| ![Simulator Screenshot - iPhone 15 Pro Max - 2023-12-15 at 10 41
53](https://github.com/ooni/probe-ios/assets/17911892/38561260-bc93-4816-bb50-364908d49240)
| ![Simulator Screenshot - iPhone 15 Pro Max - 2023-12-15 at 10 41
56](https://github.com/ooni/probe-ios/assets/17911892/0aa45989-856d-4248-ba08-0ca9fbfdc29e)
| ![Simulator Screenshot - iPhone 15 Pro Max - 2023-12-15 at 10 42
01](https://github.com/ooni/probe-ios/assets/17911892/df996305-a44d-4d01-a2b5-c4916982f408)|
| ![Simulator Screenshot - iPhone 15 Pro Max - 2023-12-15 at 10 42
10](https://github.com/ooni/probe-ios/assets/17911892/27bf5542-6e6d-4c24-9d45-c9e1b4c5ccb4)
| ![Simulator Screenshot - iPhone 15 Pro Max - 2023-12-15 at 15 38
53](https://github.com/ooni/probe-ios/assets/17911892/27ac3c78-cf9f-4ad9-8095-de8200bcc487)
| ![Simulator Screenshot - iPhone 15 Pro Max - 2023-12-15 at 15 38
56](https://github.com/ooni/probe-ios/assets/17911892/76fee883-4a76-4293-a5bd-a457c444b39a)|
@aanorbel aanorbel reopened this Jan 29, 2024
@aanorbel aanorbel mentioned this issue Feb 9, 2024
Merged
aanorbel added a commit to ooni/probe-ios that referenced this issue Mar 4, 2024
@aanorbel
fix: RTL doesn't work on iOS (#553)
4fbce3e 
Fixes  ooni/probe#2578

## Proposed Changes

  - Change alignment for various layouts

| After | Before |
|-|-|
|
![middle_box_after](https://github.com/ooni/probe-ios/assets/17911892/c2362d5f-10cf-45d0-8258-86d8a27a57d3)
|
![middle_box_before](https://github.com/ooni/probe-ios/assets/17911892/7a237999-03c3-4127-89c0-32dbd56653dd)
|
|
![test_options_after](https://github.com/ooni/probe-ios/assets/17911892/906e87b3-7dbc-4ffd-83b1-ff5bef1a6cd7)
|
![test_options_before](https://github.com/ooni/probe-ios/assets/17911892/8b71cfa4-36af-47b8-ac44-99392f114ac4)
|
|
![websites_resukts_after](https://github.com/ooni/probe-ios/assets/17911892/4325d6b1-bac5-4448-81f0-cf7d963e082f)|
![websites_results_before](https://github.com/ooni/probe-ios/assets/17911892/4c11f125-6126-4de7-a41b-270116c79505)|

|![about_after](https://github.com/ooni/probe-ios/assets/17911892/38035ac5-c653-4c6d-98cf-92fc6ef8d034)|
![about_before](https://github.com/ooni/probe-ios/assets/17911892/f0dfce54-3d60-4bd0-ba80-727cf1ea58f9)
|
|
![circumvention_after](https://github.com/ooni/probe-ios/assets/17911892/1c9f9f58-cc59-4142-a174-8b3da49be07e)
|
![circumvention_before](https://github.com/ooni/probe-ios/assets/17911892/fae8a565-d99c-427a-ad6a-d9554c417f36)|
|
![instant_messaging_after](https://github.com/ooni/probe-ios/assets/17911892/4e90aa72-60de-44f2-ba7f-ecc8a7c2d18f)
|
![instant_messaging_before](https://github.com/ooni/probe-ios/assets/17911892/bd81787b-9475-437f-a7f5-812a807db1e6)
|
|
![overview_after](https://github.com/ooni/probe-ios/assets/17911892/78089542-b126-4989-a324-f5082393c98f)
|
![overview_before](https://github.com/ooni/probe-ios/assets/17911892/dc1a0e3f-7ffa-4cb9-a273-53e6a8fd1a7c)
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aanorbel aanorbel

Labels
bug Something isn't working enhancement improving existing code or new feature funder/otffoss2023-2024 localization ooni/probe-mobile issues related to OONI Probe mobile platform/ios priority/medium triage user feedback requests that have been added to the backlog as a direct result of user feedback or testing ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: RTL doesn't work on iOS ooni/probe-ios
fix: RTL doesn't work on iOS ooni/probe-ios
3 participants
@jbonisteel @sloncocs @aanorbel