Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We use a combination of authored date and commit date #38

Open
cespare opened this issue Sep 7, 2011 · 0 comments
Open

We use a combination of authored date and commit date #38

cespare opened this issue Sep 7, 2011 · 0 comments
Labels

Comments

@cespare
Copy link
Contributor

cespare commented Sep 7, 2011

We are currently using the authored date for commit ingestion (so that's what is stored in the DB), but the commit date for searching. An example is the commit 45f31c9027782db69c6b76c5a04a1e833437891c in the backlot repo -- it will show as '6 hours ago' in the saved search but '4 days ago' in the commit view (as of writing this commit).

We definitely need to use the commit date for searching (otherwise newly pushed commits won't appear at the top of the list), so my vote is that we use commit date everywhere or store both dates and display them both in the commit metadata section.

We also need to think about how we will fix production data in either case.

@ghost ghost assigned cespare May 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant