Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Player as a React component #712

Closed
tarjei opened this issue Jan 20, 2017 · 4 comments
Closed

Export Player as a React component #712

tarjei opened this issue Jan 20, 2017 · 4 comments

Comments

@tarjei
Copy link

tarjei commented Jan 20, 2017

Hi,

When using the player within React we are experiencing some issues (a PR is coming for one of them).

What would be cool is if this project also exported an NPM module that exported the skin as a react component so that it was possible to use it within an existing react installation like this:

... my react code

<OoyalaPlayer {...props} />

... some more code

This would make it much easier for us to embed the player and also it would keep us from having a react.mount() within a react.mount() call.

Have you tried / prototyped something like this?

@mistermendez
Copy link
Contributor

Only html5-skin uses React.js and is one of many plugins to the core player.

We'd need to update the core player and most plugins to be in CommonJS format to work with NPM. Both are reasonable updates to make for a modern web app but require changes to the entire Ooyala ecosystem.

We'll keep you posted as this develops, thanks for the great feedback!

@tarjei
Copy link
Author

tarjei commented Jan 25, 2017

It would be great if you just published a version that required core.js to be loaded when the component gets instantiated. The component could wrap an inner component that became the plugin to the normal Ooyala player - think like you would wrap a Jquery plugin in React.

I'm looking forward to seeing the other changes done to the player as well :)

PS: Have you considered something like Elm to wrap the player. AFAIK that would give you a smaller player than using React and would also ensure less errors within the player code.

Regards,
Tarjei

@BornaP
Copy link

BornaP commented Sep 19, 2018

Hi @mistermendez, are there any updates on this issue?

@aldigun
Copy link

aldigun commented Sep 20, 2018

Vast majority of our customer profiles do not actually build the player code around npm. However, this is still a great idea that we can plan in the future.

@aldigun aldigun closed this as completed Sep 20, 2018
@ooyala ooyala deleted a comment from tarjei Sep 20, 2018
@ooyala ooyala locked as resolved and limited conversation to collaborators Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants