-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Player as a React component #712
Comments
Only html5-skin uses React.js and is one of many plugins to the core player. We'd need to update the core player and most plugins to be in CommonJS format to work with NPM. Both are reasonable updates to make for a modern web app but require changes to the entire Ooyala ecosystem. We'll keep you posted as this develops, thanks for the great feedback! |
It would be great if you just published a version that required core.js to be loaded when the component gets instantiated. The component could wrap an inner component that became the plugin to the normal Ooyala player - think like you would wrap a Jquery plugin in React. I'm looking forward to seeing the other changes done to the player as well :) PS: Have you considered something like Elm to wrap the player. AFAIK that would give you a smaller player than using React and would also ensure less errors within the player code. Regards, |
Hi @mistermendez, are there any updates on this issue? |
Vast majority of our customer profiles do not actually build the player code around npm. However, this is still a great idea that we can plan in the future. |
Hi,
When using the player within React we are experiencing some issues (a PR is coming for one of them).
What would be cool is if this project also exported an NPM module that exported the skin as a react component so that it was possible to use it within an existing react installation like this:
This would make it much easier for us to embed the player and also it would keep us from having a react.mount() within a react.mount() call.
Have you tried / prototyped something like this?
The text was updated successfully, but these errors were encountered: