Fix branch/location/country validation (serious bug!) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2015 18:51
The rules for location validation were supposed to be applied to the branch (ouch), however, in reality they were applied to the country (ouch, ouch). Since locations may not contain the letter "0" as the second letter, some ISO countries such as "RO" (Romania) never passed the BIC validation.
Ruby 1.9 and Rubinius 2.1 have reached their EOL long ago and some gems fail to build on it.
|
@opahk Could you take a look at this PR? It fixes a really serious bug. (I had to update the Travis config as well since some Rubies which reached their EOT failed to build a test environment due to gems which have dropped support for those Rubies. It's all green now.) Thanks a lot! |
|
@svoop thanks for the PR and your patience. Looking into it now. |
opahk
pushed a commit
that referenced
this pull request
Dec 21, 2015
Fix branch/location/country validation (serious bug!)
|
@svoop I've pushed a new revision to rubygems. Thanks for finding and fixing the bug. I also appreciate the naming improvement. |
|
@opahk Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You've mixed up country, location and branch in a way which lets all ISO countries which have the letter "O" as the second letter always fail validation – most notably "RO" (Romania).
Furthermore, I've added the rspec-its gem as a development dependency to fix the test suite.
Thanks for considering a timely merge and version bump!