Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opal::RSpec::RakeTask #67

Closed
usergenic opened this issue Sep 23, 2016 · 4 comments
Closed

Opal::RSpec::RakeTask #67

usergenic opened this issue Sep 23, 2016 · 4 comments
Labels

Comments

@usergenic
Copy link

References Net::HTTP at https://github.com/opal/opal-rspec/blob/master/lib/opal/rspec/rake_task.rb#L47

This causes a const-missing error unless you add require 'net/http' in your Rakefile. Maybe just put that require in the rake_task.rb where it belongs?

@wied03
Copy link
Contributor

wied03 commented Sep 23, 2016

Good catch. Thanks. I need to get back to work on this soon!

@wied03 wied03 added the bug label Sep 23, 2016
@wied03
Copy link
Contributor

wied03 commented Sep 24, 2016

@usergenic - What version of Ruby were you using?

It should absolutely be required and I have no idea why (it has been a long week) but for some reason it does not give me that error. I'm trying to replicate this with a test (see https://github.com/opal/opal-rspec/blob/bugs/http_require/Rakefile#L27-L32) before I fix it so that it does not regress.

We're not using Bundler.require anywhere so not sure why it's working for me without the require.

@usergenic
Copy link
Author

ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15]

@elia
Copy link
Member

elia commented Nov 9, 2018

seems it has been fixed a long time ago 😄

@elia elia closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants